Skip to content

Commit 30254a1

Browse files
committed
src: use Maybe<void> in ProcessEmitWarningSync
Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
1 parent ed22a68 commit 30254a1

2 files changed

Lines changed: 5 additions & 4 deletions

File tree

src/node_process.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ inline v8::Maybe<bool> ProcessEmitWarning(Environment* env,
3737
const char* fmt,
3838
Args&&... args);
3939

40-
v8::Maybe<bool> ProcessEmitWarningSync(Environment* env,
40+
v8::Maybe<void> ProcessEmitWarningSync(Environment* env,
4141
std::string_view message);
4242
v8::Maybe<bool> ProcessEmitExperimentalWarning(Environment* env,
4343
const std::string& warning);

src/node_process_events.cc

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ using v8::Function;
1010
using v8::HandleScope;
1111
using v8::Isolate;
1212
using v8::Just;
13+
using v8::JustVoid;
1314
using v8::Local;
1415
using v8::Maybe;
1516
using v8::MaybeLocal;
@@ -18,7 +19,7 @@ using v8::Object;
1819
using v8::String;
1920
using v8::Value;
2021

21-
Maybe<bool> ProcessEmitWarningSync(Environment* env, std::string_view message) {
22+
Maybe<void> ProcessEmitWarningSync(Environment* env, std::string_view message) {
2223
Isolate* isolate = env->isolate();
2324
Local<Context> context = env->context();
2425
Local<String> message_string = OneByteString(isolate, message);
@@ -31,9 +32,9 @@ Maybe<bool> ProcessEmitWarningSync(Environment* env, std::string_view message) {
3132
if (emit_function.As<Function>()
3233
->Call(context, v8::Undefined(isolate), arraysize(argv), argv)
3334
.IsEmpty()) {
34-
return Nothing<bool>();
35+
return Nothing<void>();
3536
}
36-
return Just(true);
37+
return JustVoid();
3738
}
3839

3940
MaybeLocal<Value> ProcessEmit(Environment* env,

0 commit comments

Comments
 (0)