Skip to content

Commit 76a73d6

Browse files
joyeecheungaduh95
authored andcommitted
build: expose libplatform symbols in shared libnode
This requires setting BUILDING_V8_PLATFORM_SHARED to expose the public symbols since we build with hidden visibility by default. PR-URL: #61144 Fixes: #61102 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Richard Lau <[email protected]>
1 parent ef8d26c commit 76a73d6

File tree

2 files changed

+11
-0
lines changed

2 files changed

+11
-0
lines changed

node.gypi

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,9 +50,11 @@
5050
'defines': [
5151
'USING_UV_SHARED',
5252
'USING_V8_SHARED',
53+
'USING_V8_PLATFORM_SHARED',
5354
'BUILDING_NODE_EXTENSION'
5455
],
5556
'defines!': [
57+
'BUILDING_V8_PLATFORM_SHARED=1',
5658
'BUILDING_V8_SHARED=1',
5759
'BUILDING_UV_SHARED=1'
5860
]

tools/v8_gypfiles/v8.gyp

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@
5353
['OS!="aix" and OS!="os400"', {
5454
'defines': [
5555
'BUILDING_V8_SHARED', # Make V8_EXPORT visible.
56+
'BUILDING_V8_PLATFORM_SHARED', # Make V8_PLATFORM_EXPORT visible.
5657
]
5758
}],
5859
['node_shared=="true"', {
@@ -1284,6 +1285,7 @@
12841285
['component=="shared_library"', {
12851286
'defines': [
12861287
'BUILDING_V8_SHARED',
1288+
'BUILDING_V8_PLATFORM_SHARED',
12871289
],
12881290
}],
12891291
['v8_enable_i18n_support==1', {
@@ -1353,6 +1355,7 @@
13531355
'defines!': [
13541356
'_HAS_EXCEPTIONS=0',
13551357
'BUILDING_V8_SHARED=1',
1358+
'BUILDING_V8_PLATFORM_SHARED=1',
13561359
],
13571360
'cflags_cc!': ['-fno-exceptions'],
13581361
'cflags_cc': ['-fexceptions'],
@@ -1379,6 +1382,7 @@
13791382
'defines!': [
13801383
'_HAS_EXCEPTIONS=0',
13811384
'BUILDING_V8_SHARED=1',
1385+
'BUILDING_V8_PLATFORM_SHARED=1',
13821386
],
13831387
'cflags_cc!': ['-fno-exceptions'],
13841388
'cflags_cc': ['-fexceptions'],
@@ -1720,6 +1724,7 @@
17201724
],
17211725
'defines!': [
17221726
'BUILDING_V8_SHARED=1',
1727+
'BUILDING_V8_PLATFORM_SHARED=1',
17231728
],
17241729
'dependencies': [
17251730
'v8_libbase',
@@ -1801,6 +1806,7 @@
18011806
'defines!': [
18021807
'_HAS_EXCEPTIONS=0',
18031808
'BUILDING_V8_SHARED=1',
1809+
'BUILDING_V8_PLATFORM_SHARED=1',
18041810
],
18051811
'cflags_cc!': ['-fno-exceptions'],
18061812
'cflags_cc': ['-fexceptions'],
@@ -1844,6 +1850,7 @@
18441850
'defines!': [
18451851
'_HAS_EXCEPTIONS=0',
18461852
'BUILDING_V8_SHARED=1',
1853+
'BUILDING_V8_PLATFORM_SHARED=1',
18471854
],
18481855
'msvs_settings': {
18491856
'VCCLCompilerTool': {
@@ -2058,10 +2065,12 @@
20582065
],
20592066
'defines': [
20602067
'BUILDING_V8_SHARED',
2068+
'BUILDING_V8_PLATFORM_SHARED',
20612069
],
20622070
'direct_dependent_settings': {
20632071
'defines': [
20642072
'USING_V8_SHARED',
2073+
'USING_V8_PLATFORM_SHARED',
20652074
],
20662075
},
20672076
'conditions': [

0 commit comments

Comments
 (0)