2020// USE OR OTHER DEALINGS IN THE SOFTWARE.
2121
2222'use strict' ;
23- const common = require ( '../common' ) ;
24- const assert = require ( 'assert' ) ;
2523
26- const dns = require ( 'dns' ) ;
24+ require ( '../common' ) ;
25+
26+ const { test } = require ( 'node:test' ) ;
27+ const assert = require ( 'node:assert' ) ;
28+ const dns = require ( 'node:dns' ) ;
2729const dnsPromises = dns . promises ;
2830
29- ( async function ( ) {
31+ test ( 'dns promises lookup' , async ( t ) => {
3032 let res ;
3133
3234 res = await dnsPromises . lookup ( null ) ;
@@ -40,54 +42,58 @@ const dnsPromises = dns.promises;
4042 res = await dnsPromises . lookup ( '::1' ) ;
4143 assert . strictEqual ( res . address , '::1' ) ;
4244 assert . strictEqual ( res . family , 6 ) ;
43- } ) ( ) . then ( common . mustCall ( ) ) ;
45+ } ) ;
4446
45- // Try resolution without hostname.
46- dns . lookup ( null , common . mustSucceed ( ( result , addressType ) => {
47- assert . strictEqual ( result , null ) ;
48- assert . strictEqual ( addressType , 4 ) ;
49- } ) ) ;
47+ test ( 'dns callback lookup' , ( t ) => {
48+ dns . lookup ( null , ( err , result , addressType ) => {
49+ assert . strictEqual ( err , null ) ;
50+ assert . strictEqual ( result , null ) ;
51+ assert . strictEqual ( addressType , 4 ) ;
52+ } ) ;
5053
51- dns . lookup ( '127.0.0.1' , common . mustSucceed ( ( result , addressType ) => {
52- assert . strictEqual ( result , '127.0.0.1' ) ;
53- assert . strictEqual ( addressType , 4 ) ;
54- } ) ) ;
54+ dns . lookup ( '127.0.0.1' , ( err , result , addressType ) => {
55+ assert . strictEqual ( err , null ) ;
56+ assert . strictEqual ( result , '127.0.0.1' ) ;
57+ assert . strictEqual ( addressType , 4 ) ;
58+ } ) ;
5559
56- dns . lookup ( '::1' , common . mustSucceed ( ( result , addressType ) => {
57- assert . strictEqual ( result , '::1' ) ;
58- assert . strictEqual ( addressType , 6 ) ;
59- } ) ) ;
60+ dns . lookup ( '::1' , ( err , result , addressType ) => {
61+ assert . strictEqual ( err , null ) ;
62+ assert . strictEqual ( result , '::1' ) ;
63+ assert . strictEqual ( addressType , 6 ) ;
64+ } ) ;
65+ } ) ;
6066
61- [
62- // Try calling resolve with an unsupported type.
63- 'HI' ,
64- // Try calling resolve with an unsupported type that's an object key
65- 'toString' ,
66- ] . forEach ( ( val ) => {
67- const err = {
68- code : 'ERR_INVALID_ARG_VALUE' ,
69- name : 'TypeError' ,
70- message : `The argument 'rrtype' is invalid. Received '${ val } ,
71- } ;
67+ test ( 'unsupported rrtype resolves' , ( t ) => {
68+ [
69+ // Try calling resolve with an unsupported type.
70+ 'HI' ,
71+ // Try calling resolve with an unsupported type that's an object key
72+ 'toString' ,
73+ ] . forEach ( ( val ) => {
74+ const err = {
75+ code : 'ERR_INVALID_ARG_VALUE' ,
76+ name : 'TypeError' ,
77+ message : `The argument 'rrtype' is invalid. Received '${ val } ,
78+ } ;
7279
73- assert . throws (
74- ( ) => dns . resolve ( 'www.google.com' , val ) ,
75- err
76- ) ;
80+ assert . throws (
81+ ( ) => dns . resolve ( 'www.google.com' , val ) ,
82+ err
83+ ) ;
7784
78- assert . throws ( ( ) => dnsPromises . resolve ( 'www.google.com' , val ) , err ) ;
85+ assert . throws ( ( ) => dnsPromises . resolve ( 'www.google.com' , val ) , err ) ;
86+ } ) ;
7987} ) ;
8088
81- // Windows doesn't usually have an entry for localhost 127.0.0.1 in
82- // C:\Windows\System32\drivers\etc\hosts
83- // so we disable this test on Windows.
84- // IBMi reports `ENOTFOUND` when get hostname by address 127.0.0.1
85- if ( ! common . isWindows && ! common . isIBMi ) {
86- dns . reverse ( '127.0.0.1' , common . mustSucceed ( ( domains ) => {
87- assert . ok ( Array . isArray ( domains ) ) ;
88- } ) ) ;
89+ test ( 'reverse DNS lookup (non-Windows, non-IBMi)' , async ( t ) => {
90+ if ( ! process . platform . startsWith ( 'win' ) && process . platform !== 'aix' ) {
91+ dns . reverse ( '127.0.0.1' , ( err , domains ) => {
92+ assert . strictEqual ( err , null ) ;
93+ assert . ok ( Array . isArray ( domains ) ) ;
94+ } ) ;
8995
90- ( async function ( ) {
91- assert . ok ( Array . isArray ( await dnsPromises . reverse ( '127.0.0.1' ) ) ) ;
92- } ) ( ) . then ( common . mustCall ( ) ) ;
93- }
96+ const domains = await dnsPromises . reverse ( '127.0.0.1' ) ;
97+ assert . ok ( Array . isArray ( domains ) ) ;
98+ }
99+ } ) ;
0 commit comments