errors: support possible deletion of globalThis.Error

targos · targos · commit de9118b87061 · 2020-10-04T15:56:49.000+02:00
Do not crash trying to access prepareStackTrace on `undefined`.
diff --git a/lib/internal/errors.js b/lib/internal/errors.js
@@ -81,7 +81,7 @@ const maybeOverridePrepareStackTrace = (globalThis, error, trace) => {
   // https://crbug.com/v8/7848
   // `globalThis` is the global that contains the constructor which
   // created `error`.
-  if (typeof globalThis.Error.prepareStackTrace === 'function') {
+  if (typeof globalThis.Error?.prepareStackTrace === 'function') {
     return globalThis.Error.prepareStackTrace(error, trace);
   }
   // We still have legacy usage that depends on the main context's `Error`

Original file line number	Diff line number	Diff line change
`@@ -81,7 +81,7 @@ const maybeOverridePrepareStackTrace = (globalThis, error, trace) => {`
`81`	`81`	`// https://crbug.com/v8/7848`
`82`	`82`	// `globalThis` is the global that contains the constructor which
`83`	`83`	// created `error`.
`84`		`- if (typeof globalThis.Error.prepareStackTrace === 'function') {`
	`84`	`+ if (typeof globalThis.Error?.prepareStackTrace === 'function') {`
`85`	`85`	`return globalThis.Error.prepareStackTrace(error, trace);`
`86`	`86`	`}`
`87`	`87`	// We still have legacy usage that depends on the main context's `Error`