all the one off fixes for arrow functions are pretty untenable, so this version uses babel, which adds 2 wrinkles

• some of the replacements need to be rewritten to use const or let because now those are being fixed after the replacements
• a couple tests have top level returns so need to be wrapped in an iefe (which is why babel must go after the replacements).

babel does something funky with the white space so while I have retainLines on right now to be able to eye ball the changes we probably want to turn that off.

and we are green https://travis-ci.org/nodejs/readable-stream/builds/111795595

what's the output without retainLine?

I would prefer different line numbers from core but a more readable thing. Line numbers can potentially be different anyway (because of the replacements).

It puts conditionals that don't have curly braces are put on to a single
line, not a big deal but it makes comparing the diff tricky, I can rerun it
with that off now that it passes.

On Fri, Feb 26, 2016, 3:07 AM Matteo Collina notifications@github.com
wrote:

what's the output without retainLine?

I would prefer different line numbers from core but a more readable thing.
Line numbers can potentially be different anyway (because of the
replacements).

—
Reply to this email directly or view it on GitHub
#186 (comment)
.

ok removed retain lines

👍. I would bump the minor here, just because it's a significant change (babel), and my change might or might not land in v4.x.x.

hm I tend to not count build changes in terms of features, but it is a
largish change so I'm on the fence here

On Fri, Feb 26, 2016 at 8:52 AM Matteo Collina notifications@github.com
wrote:

[image: 👍]. I would bump the minor here, just because it's a
significant change (babel), and my change might or might not land in v4.x.x.

—
Reply to this email directly or view it on GitHub
#186 (comment)
.

hey guys can I get a yay or nay on this one

LGTM