fixuP

Author: ronag

lib/dispatcher/dispatcher.js

@@ -44,6 +44,12 @@ const kOnConnect = Symbol('onConnect')
 const kOnDisconnect = Symbol('onDisconnect')
 const kOnConnectionError = Symbol('onConnectionError')
 
+const registry = new FinalizationRegistry(({ dispatcher, handlers }) => {
+  for (const [event, listener] of handlers) {
+    dispatcher.off(event, listener)
+  }
+});
+
 class ComposedDispatcher extends Dispatcher {
   #dispatcher
   #dispatch
@@ -54,17 +60,18 @@ class ComposedDispatcher extends Dispatcher {
     this.#dispatcher = dispatcher
     this.#dispatch = dispatch
 
-    this[kOnDrain] = (...args) => this.emit('drain', ...args)
-    this[kOnConnect] = (...args) => this.emit('connect', ...args)
-    this[kOnDisconnect] = (...args) => this.emit('disconnect', ...args)
-    this[kOnConnectionError] = (...args) => this.emit('connectionError', ...args)
-
-    // TODO (fix): These must be weak references...
-    this.#dispatcher
-      .on('drain', this[kOnDrain])
-      .on('connect', this[kOnConnect])
-      .on('disconnect', this[kOnDisconnect])
-      .on('connectionError', this[kOnConnectionError])
+    const weakThis = new WeakRef(this)
+    const handlers = []
+
+    for (const event of ['drain', 'connect', 'disconnect', 'connectionError']) {
+      const listener = function (...args) {
+        weakThis.deref()?.emit(event, ...args)
+      }
+      handlers.push([event, listener])
+      dispatcher.on(event, listener)
+    }
+
+    registry.register(this, { dispatcher, handlers })
   }
 
   dispatch (...args) {