Sync to 9.0.0-preview.3.24172.4

* Implement quoting for custom SqlExpressions
* Type mapping visitor changes
* React to SqlConstantExpression changes

Author: roji

.github/workflows/build.yml

@@ -11,7 +11,7 @@ on:
   pull_request:
 
 env:
-  dotnet_sdk_version: '8.0.100'
+  dotnet_sdk_version: '9.0.100-preview.3.24204.13'
   postgis_version: 3
   DOTNET_SKIP_FIRST_TIME_EXPERIENCE: true
 

.github/workflows/codeql-analysis.yml

@@ -27,7 +27,7 @@ on:
     - cron: '30 22 * * 6'
 
 env:
-  dotnet_sdk_version: '8.0.100'
+  dotnet_sdk_version: '9.0.100-preview.3.24204.13'
 
 jobs:
   analyze:

Directory.Build.props

@@ -12,7 +12,7 @@
     <ImplicitUsings>true</ImplicitUsings>
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
 
-    <Copyright>Copyright 2023 © The Npgsql Development Team</Copyright>
+    <Copyright>Copyright 2024 © The Npgsql Development Team</Copyright>
     <Company>Npgsql</Company>
     <PublishRepositoryUrl>true</PublishRepositoryUrl>
     <PackageLicenseExpression>PostgreSQL</PackageLicenseExpression>

Directory.Packages.props

@@ -1,7 +1,7 @@
   <Project>
   <PropertyGroup>
-    <EFCoreVersion>9.0.0-preview.2.24128.4</EFCoreVersion>
-    <MicrosoftExtensionsVersion>9.0.0-preview.2.24128.5</MicrosoftExtensionsVersion>
+    <EFCoreVersion>9.0.0-preview.3.24172.4</EFCoreVersion>
+    <MicrosoftExtensionsVersion>9.0.0-preview.3.24172.9</MicrosoftExtensionsVersion>
     <NpgsqlVersion>8.0.2</NpgsqlVersion>
   </PropertyGroup>
 
@@ -23,8 +23,12 @@
 
     <PackageVersion Include="Microsoft.SourceLink.GitHub" Version="8.0.0" />
     <PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.8.0" />
-    <PackageVersion Include="xunit" Version="2.6.1" />
-    <PackageVersion Include="xunit.runner.visualstudio" Version="2.5.6" />
+<!--    <PackageVersion Include="xunit" Version="2.6.7-pre.5" />-->
+<!--    <PackageVersion Include="xunit.runner.visualstudio" Version="2.5.7-pre.8" />-->
+    <PackageVersion Include="xunit" Version="2.7.1" />
+    <PackageVersion Include="xunit.assert" Version="2.7.1" />
+    <PackageVersion Include="xunit.core" Version="2.7.1" />
+    <PackageVersion Include="xunit.runner.visualstudio" Version="2.5.7" />
     <PackageVersion Include="GitHubActionsTestLogger" Version="2.3.3" />
   </ItemGroup>
 </Project>

EFCore.PG.sln.DotSettings

@@ -1,7 +1,7 @@
 {
   "sdk": {
-    "version": "8.0.100-rc.2.23502.2",
+    "version": "9.0.100-preview.3.24204.13",
     "rollForward": "latestMajor",
-    "allowPrerelease": "true"
+    "allowPrerelease": true
   }
 }

global.json

@@ -9,6 +9,9 @@ private PendingDateTimeZoneProviderExpression()
     {
     }
 
+    public override Expression Quote()
+        => throw new UnreachableException("PendingDateTimeZoneProviderExpression is a temporary tree representation and should never be quoted");
+
     protected override void Print(ExpressionPrinter expressionPrinter)
         => expressionPrinter.Append("TZDB");
 }

src/EFCore.PG.NodaTime/Query/Internal/PendingDateTimeZoneProviderExpression.cs

@@ -12,6 +12,9 @@ internal PendingZonedDateTimeExpression(SqlExpression operand, SqlExpression tim
 
     internal SqlExpression TimeZoneId { get; }
 
+    public override Expression Quote()
+        => throw new UnreachableException("PendingDateTimeZoneProviderExpression is a temporary tree representation and should never be quoted");
+
     protected override void Print(ExpressionPrinter expressionPrinter)
     {
         expressionPrinter.Visit(Operand);

src/EFCore.PG.NodaTime/Query/Internal/PendingZonedDateTimeExpression.cs

@@ -9,6 +9,7 @@
     <Description>PostgreSQL/Npgsql provider for Entity Framework Core.</Description>
     <PackageTags>npgsql;postgresql;postgres;Entity Framework Core;entity-framework-core;ef;efcore;orm;sql</PackageTags>
     <PackageReadmeFile>README.md</PackageReadmeFile>
+    <NoWarn>EF1003</NoWarn> <!-- Precompiled query is experimental -->
   </PropertyGroup>
 
   <ItemGroup>

src/EFCore.PG/EFCore.PG.csproj

@@ -78,7 +78,7 @@ public NpgsqlObjectToStringTranslator(IRelationalTypeMappingSource typeMappingSo
                             _sqlExpressionFactory.Equal(instance, _sqlExpressionFactory.Constant(true)),
                             _sqlExpressionFactory.Constant(true.ToString()))
                     },
-                    _sqlExpressionFactory.Constant(null))
+                    _sqlExpressionFactory.Constant(null, typeof(string)))
                 : _sqlExpressionFactory.Case(
                     new[]
                     {