fix(linting): no-unused-vars

Author: wraithgar

bin/npx-cli.js

@@ -26,7 +26,7 @@ const removed = new Set([
 
 const { definitions, shorthands } = require('@npmcli/config/lib/definitions')
 const npmSwitches = Object.entries(definitions)
-  .filter(([key, { type }]) => type === Boolean ||
+  .filter(([, { type }]) => type === Boolean ||
     (Array.isArray(type) && type.includes(Boolean)))
   .map(([key]) => key)
 

docs/lib/index.js

@@ -119,7 +119,7 @@ const replaceConfig = (src, { path }) => {
   }
 
   const allConfig = Object.entries(definitions).sort(sort)
-    .map(([_, def]) => def.describe())
+    .map(([, def]) => def.describe())
     .join('\n\n')
 
   return src.replace(replacer, allConfig)

lib/commands/adduser.js

@@ -12,7 +12,7 @@ class AddUser extends BaseCommand {
     'auth-type',
   ]
 
-  async exec (args) {
+  async exec () {
     const scope = this.npm.config.get('scope')
     let registry = this.npm.config.get('registry')
 

lib/commands/ci.js

@@ -81,7 +81,7 @@ class CI extends ArboristWorkspaceCmd {
       await time.start('npm-ci:rm', async () => {
         const path = `${where}/node_modules`
         // get the list of entries so we can skip the glob for performance
-        const entries = await fs.readdir(path, null).catch(er => [])
+        const entries = await fs.readdir(path, null).catch(() => [])
         return Promise.all(entries.map(f => fs.rm(`${path}/${f}`,
           { force: true, recursive: true })))
       })

lib/commands/completion.js

@@ -248,7 +248,7 @@ const configCompl = opts => {
 
 // expand with the valid values of various config values.
 // not yet implemented.
-const configValueCompl = opts => []
+const configValueCompl = () => []
 
 // check if the thing is a flag or not.
 const isFlag = word => {
@@ -265,7 +265,7 @@ const isFlag = word => {
 
 // complete against the npm commands
 // if they all resolve to the same thing, just return the thing it already is
-const cmdCompl = (opts, npm) => {
+const cmdCompl = (opts) => {
   const allCommands = commands.concat(Object.keys(aliases))
   const matches = allCommands.filter(c => c.startsWith(opts.partialWord))
   if (!matches.length) {

lib/commands/dedupe.js

@@ -21,7 +21,7 @@ class Dedupe extends ArboristWorkspaceCmd {
     ...super.params,
   ]
 
-  async exec (args) {
+  async exec () {
     if (this.npm.global) {
       const er = new Error('`npm dedupe` does not work in global mode.')
       er.code = 'EDEDUPEGLOBAL'

lib/commands/diff.js

@@ -78,7 +78,7 @@ class Diff extends BaseCommand {
 
   // get the package name from the packument at `path`
   // throws if no packument is present OR if it does not have `name` attribute
-  async packageName (path) {
+  async packageName () {
     let name
     try {
       const { content: pkg } = await pkgJson.normalize(this.prefix)
@@ -103,7 +103,7 @@ class Diff extends BaseCommand {
     // no arguments, defaults to comparing cwd
     // to its latest published registry version
     if (!a) {
-      const pkgName = await this.packageName(this.prefix)
+      const pkgName = await this.packageName()
       return [
         `${pkgName}@${this.npm.config.get('tag')}`,
         `file:${this.prefix.replace(/#/g, '%23')}`,

lib/commands/doctor.js

@@ -254,7 +254,7 @@ class Doctor extends BaseCommand {
         }
 
         if (st.isDirectory()) {
-          const entries = await readdir(f).catch(er => {
+          const entries = await readdir(f).catch(() => {
             ok = false
             log.warn('doctor', 'checkFilesPermission', 'error reading directory ' + f)
             return []

lib/commands/find-dupes.js

@@ -19,7 +19,7 @@ class FindDupes extends ArboristWorkspaceCmd {
     ...super.params,
   ]
 
-  async exec (args) {
+  async exec () {
     this.npm.config.set('dry-run', true)
     return this.npm.exec('dedupe', [])
   }

lib/commands/help-search.js

@@ -22,7 +22,7 @@ class HelpSearch extends BaseCommand {
     // preserve glob@8 behavior
     files = files.sort((a, b) => a.localeCompare(b, 'en'))
     const data = await this.readFiles(files)
-    const results = await this.searchFiles(args, data, files)
+    const results = await this.searchFiles(args, data)
     const formatted = this.formatResults(args, results)
     if (!formatted.trim()) {
       output.standard(`No matches in help for: ${args.join(' ')}\n`)
@@ -40,7 +40,7 @@ class HelpSearch extends BaseCommand {
     return res
   }
 
-  async searchFiles (args, data, files) {
+  async searchFiles (args, data) {
     const results = []
     for (const [file, content] of Object.entries(data)) {
       const lowerCase = content.toLowerCase()