Closed
Conversation
This includes all positional args (ie, not anything that is a config), except for the third positional arg when running `npm token revoke ...`, since that is also a secret. Makes the `ps` entry a bit more useful than just "npm", so users can at least get some clue what npm is doing, while minimizing the degree to which we leak anything secret. Closes: #1927 Fixes: https://npm.community/t/8400 Related: tmux-plugins/tmux-resurrect#201
ruyadorno
approved these changes
Nov 11, 2020
ruyadorno
added
Release 7.x
darcyclarke
pushed a commit
that referenced
this pull request
Nov 13, 2020
This includes all positional args (ie, not anything that is a config), except for the third positional arg when running `npm token revoke ...`, since that is also a secret. Makes the `ps` entry a bit more useful than just "npm", so users can at least get some clue what npm is doing, while minimizing the degree to which we leak anything secret. Closes: #1927 Fixes: https://npm.community/t/8400 Related: tmux-plugins/tmux-resurrect#201 Credit: @isaacs Close: #2154 Reviewed-by: @ruyadorno
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes all positional args (ie, not anything that is a config),
except for the third positional arg when running
npm token revoke ...,since that is also a secret.
Makes the
psentry a bit more useful than just "npm", so users can atleast get some clue what npm is doing, while minimizing the degree to
which we leak anything secret.
Closes: #1927
Fixes: https://npm.community/t/8400
Related: tmux-plugins/tmux-resurrect#201
References