raise an error early if publishing without login, registry#2360
Closed
isaacs wants to merge 0 commit intorelease/v7.3.0from
Closed
raise an error early if publishing without login, registry#2360isaacs wants to merge 0 commit intorelease/v7.3.0from
isaacs wants to merge 0 commit intorelease/v7.3.0from
Conversation
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
fa55ea3 to
15e3053
Compare
nlf
approved these changes
Dec 18, 2020
Contributor
nlf
left a comment
There was a problem hiding this comment.
fast failing is definitely the way to go here, this is great
isaacs
added a commit
that referenced
this pull request
Dec 18, 2020
15e3053 to
be4a090
Compare
|
Is it possible that this is why #1937 seems to have reverted for me? I don't think your |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran into this fixing #2300 in @npmcli/config, getting weird registry errors when trying to publish while my
userconfigwas still set to a test file.References