fix(update-notifier): don't force black background#3499
Merged
wraithgar merged 1 commit intorelease-nextfrom Jul 12, 2021
Merged
fix(update-notifier): don't force black background#3499wraithgar merged 1 commit intorelease-nextfrom
wraithgar merged 1 commit intorelease-nextfrom
Conversation
darcyclarke
added
Release 7.x
nlf
approved these changes
Jul 12, 2021
Contributor
nlf
left a comment
nlf
left a comment
There was a problem hiding this comment.
yeah good call, we definitely shouldn't be forcing background colors unless we absolutely have to.. and we don't.
This looks very wrong on white terminals. npmlog still makes its `notice` logs do this but that will have to be fixed in the npmlog repo. PR-URL: #3499 Credit: @wraithgar Close: #3499 Reviewed-by: @nlf
wraithgar
force-pushed
the
gar/update-notifier-color
branch
from
e7faf43 to
c3bd10e
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This looks very wrong on white terminals.
npmlog still makes its
noticelogs do this but that will have to befixed in the npmlog repo.
References
Related to #3091