fix(unpublish): bubble up all errors parsing local package.json#7049
Merged
fix(unpublish): bubble up all errors parsing local package.json#7049
Conversation
Member
Author
wraithgar
force-pushed
the
gar/unpublish-package-json-errors
branch
from
e93d3ef to
3a42cff
Compare
If the file is there and there is any error that's always a show stopper
wraithgar
force-pushed
the
gar/unpublish-package-json-errors
branch
from
3a42cff to
82809a9
Compare
hashtagchris
approved these changes
Dec 1, 2023
Contributor
hashtagchris
left a comment
hashtagchris
left a comment
There was a problem hiding this comment.
Looks good, thanks for fixing this!
Merged
wraithgar
added a commit
that referenced
this pull request
Dec 1, 2023
If the file is there and there is any error that's always a show stopper
wraithgar
added a commit
that referenced
this pull request
Dec 1, 2023
If the file is there and there is any error that's always a show stopper
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the file is there and there is any error that's always a show stopper