fix: admin_store_credentials in mongodb needs to be false, as per upstream

ashish1099 · ashish1099 · commit 5c98dea3967f · 2025-10-15T12:14:29.000+05:30
diff --git a/modules/enableit/role/manifests/db/mongodb.pp b/modules/enableit/role/manifests/db/mongodb.pp
@@ -37,7 +37,7 @@
 #
 # @param restart_on_change Whether to restart MongoDB on configuration change. Defaults to true.
 #
-# @param create_admin Whether to create an admin user. Defaults to true.
+# @param create_admin Whether to create an admin user. Defaults to false.
 #
 # @param directory_per_db Whether to use a separate directory for each database. Defaults to false.
 #
@@ -61,7 +61,7 @@
 #
 # @param admin_roles The roles for the admin user. Defaults to ['root'].
 #
-# @param admin_store_credentials Whether to store credentials for the admin user. Defaults to true.
+# @param admin_store_credentials Whether to store credentials for the admin user. Defaults to false.
 #
 # @param log_file The log file path. Defaults to undef.
 #
@@ -92,7 +92,7 @@
   Boolean $disable_prealloc                              = false,
   Integer[1,default] $default_namespace_file_size        = 16,
   Boolean $restart_on_change                             = true,
-  Boolean $create_admin                                  = true,
+  Boolean $create_admin                                  = false,
   Boolean $directory_per_db                              = false,
   Boolean $enable_rest_api                               = false,
   Boolean $ssl                                           = false,
@@ -104,7 +104,7 @@
   Optional[String] $admin_username                       = undef,
   Optional[Eit_types::Password] $admin_password          = undef,
   Array[String] $admin_roles                             = ['root'],
-  Boolean $admin_store_credentials                       = true,
+  Boolean $admin_store_credentials                       = false,
   Optional[Stdlib::Absolutepath] $log_file               = undef,
   Optional[Integer[1,default]] $max_connections          = undef,
   Eit_types::User $monitor_user                          = 'obmondo-mon',

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@`
`37`	`37`	`#`
`38`	`38`	`# @param restart_on_change Whether to restart MongoDB on configuration change. Defaults to true.`
`39`	`39`	`#`
`40`		`-# @param create_admin Whether to create an admin user. Defaults to true.`
	`40`	`+# @param create_admin Whether to create an admin user. Defaults to false.`
`41`	`41`	`#`
`42`	`42`	`# @param directory_per_db Whether to use a separate directory for each database. Defaults to false.`
`43`	`43`	`#`
`@@ -61,7 +61,7 @@`
`61`	`61`	`#`
`62`	`62`	`# @param admin_roles The roles for the admin user. Defaults to ['root'].`
`63`	`63`	`#`
`64`		`-# @param admin_store_credentials Whether to store credentials for the admin user. Defaults to true.`
	`64`	`+# @param admin_store_credentials Whether to store credentials for the admin user. Defaults to false.`
`65`	`65`	`#`
`66`	`66`	`# @param log_file The log file path. Defaults to undef.`
`67`	`67`	`#`
`@@ -92,7 +92,7 @@`
`92`	`92`	`Boolean $disable_prealloc = false,`
`93`	`93`	`Integer[1,default] $default_namespace_file_size = 16,`
`94`	`94`	`Boolean $restart_on_change = true,`
`95`		`- Boolean $create_admin = true,`
	`95`	`+ Boolean $create_admin = false,`
`96`	`96`	`Boolean $directory_per_db = false,`
`97`	`97`	`Boolean $enable_rest_api = false,`
`98`	`98`	`Boolean $ssl = false,`
`@@ -104,7 +104,7 @@`
`104`	`104`	`Optional[String] $admin_username = undef,`
`105`	`105`	`Optional[Eit_types::Password] $admin_password = undef,`
`106`	`106`	`Array[String] $admin_roles = ['root'],`
`107`		`- Boolean $admin_store_credentials = true,`
	`107`	`+ Boolean $admin_store_credentials = false,`
`108`	`108`	`Optional[Stdlib::Absolutepath] $log_file = undef,`
`109`	`109`	`Optional[Integer[1,default]] $max_connections = undef,`
`110`	`110`	`Eit_types::User $monitor_user = 'obmondo-mon',`