Skip to content

Commit 3159547

Browse files
committed
fix: reject promise when calling 'load' instead of 'inject'
Fixes #147
1 parent 499bd72 commit 3159547

10 files changed

Lines changed: 34 additions & 10 deletions

dist/modules/ocLazyLoad.loaders.core.js

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,13 @@
114114
promises.push(jsDeferred.promise);
115115
}
116116

117-
if (params.serie && params.files.length > 0) {
117+
if (promises.length === 0) {
118+
var deferred = $q.defer(),
119+
err = "Error: no file to load has been found, if you're trying to load an existing module you should use the 'inject' method instead of 'load'.";
120+
$delegate._$log.error(err);
121+
deferred.reject(err);
122+
return deferred.promise;
123+
} else if (params.serie && params.files.length > 0) {
118124
return $q.all(promises).then(function () {
119125
return $delegate.filesLoader(config, params);
120126
});

dist/ocLazyLoad.js

Lines changed: 7 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/ocLazyLoad.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/ocLazyLoad.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/ocLazyLoad.min.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/ocLazyLoad.require.js

Lines changed: 7 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/ocLazyLoad.require.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/ocLazyLoad.require.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/ocLazyLoad.require.min.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/ocLazyLoad.loaders.core.js

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,13 @@
109109
promises.push(jsDeferred.promise);
110110
}
111111

112-
if(params.serie && params.files.length > 0) {
112+
if(promises.length === 0) {
113+
let deferred = $q.defer(),
114+
err = "Error: no file to load has been found, if you're trying to load an existing module you should use the 'inject' method instead of 'load'.";
115+
$delegate._$log.error(err);
116+
deferred.reject(err);
117+
return deferred.promise;
118+
} else if(params.serie && params.files.length > 0) {
113119
return $q.all(promises).then(() => $delegate.filesLoader(config, params));
114120
} else {
115121
return $q.all(promises).finally(res => {

0 commit comments

Comments
 (0)