Better naming for BalanceInAttFlowValidForFlowVault and fix logical condition

Author: m-Peter

fvm/evm/emulator/emulator.go

@@ -417,7 +417,7 @@ func (proc *procedure) withdrawFrom(
 		), nil
 	}
 
-	if types.BalanceInAttFlowValidForFlowVault(call.Value) {
+	if !types.AttoFlowBalanceValidForFlowVault(call.Value) {
 		return types.NewInvalidResult(
 			call.Transaction(),
 			types.ErrWithdrawBalanceRounding,

fvm/evm/impl/impl.go

@@ -654,7 +654,7 @@ func newInternalEVMTypeWithdrawFunction(
 				panic(types.ErrInvalidBalance)
 			}
 
-			if types.BalanceInAttFlowValidForFlowVault(amountValue.BigInt) {
+			if !types.AttoFlowBalanceValidForFlowVault(amountValue.BigInt) {
 				panic(types.ErrWithdrawBalanceRounding)
 			}
 

fvm/evm/types/balance.go

@@ -94,15 +94,15 @@ func BalanceConversionToUFix64ProneToRoundingError(bal Balance) bool {
 	return new(big.Int).Mod(bal, UFixToAttoConversionMultiplier).BitLen() != 0
 }
 
-// BalanceInAttFlowValidForFlowVault returns true if the given balance,
+// AttoFlowBalanceValidForFlowVault returns true if the given balance,
 // represented as atto Flow, can be stored in a Flow Vault.
 //
 // Warning! The smallest unit of Flow token that a Flow Vault (Cadence)
 // can store, is 1e10^-8 .
 // That means the minimum balance, in atto Flow, that can be stored in a Flow Vault,
 // is 1e10^10 .
-func BalanceInAttFlowValidForFlowVault(bal *big.Int) bool {
-	return bal.Cmp(UFixToAttoConversionMultiplier) < 0
+func AttoFlowBalanceValidForFlowVault(bal *big.Int) bool {
+	return bal.Cmp(UFixToAttoConversionMultiplier) >= 0
 }
 
 // Subtract balance 2 from balance 1 and returns the result as a new balance