Skip to content

fix: remove Microsoft.Extensions.Logging from flagd provider#233

Merged
toddbaert merged 1 commit intoopen-feature:mainfrom
ghelyar:flagd-remove-mel
Jul 16, 2024
Merged

fix: remove Microsoft.Extensions.Logging from flagd provider#233
toddbaert merged 1 commit intoopen-feature:mainfrom
ghelyar:flagd-remove-mel

Conversation

@ghelyar
Copy link
Contributor

@ghelyar ghelyar commented Jul 15, 2024

This PR

  • Remove Microsoft.Extensions.Logging dependencies from OpenFeature.Contrib.Providers.Flagd
  • Use SemVersion.TryParse to avoid a throw and catch

Related Issues

Fixes #232

@ghelyar ghelyar requested review from a team as code owners July 15, 2024 15:53
Signed-off-by: ghelyar <3225358+ghelyar@users.noreply.github.com>
@toddbaert
Copy link
Member

I'll review this later today.

@toddbaert
Copy link
Member

@ghelyar nice. Approving, merging and releasing.

I've also updated this issue, which has to do with some (more important) logging: #226

@toddbaert
Copy link
Member

@ghelyar ghelyar deleted the flagd-remove-mel branch July 17, 2024 07:04
weyert pushed a commit to weyert/dotnet-sdk-contrib that referenced this pull request Jun 19, 2025
…ature#233)

Signed-off-by: ghelyar <3225358+ghelyar@users.noreply.github.com>
This was referenced Dec 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

flagd dependencies on Microsoft.Extensions.Logging

4 participants