feat: Deprecate AddHostedFeatureLifecycle method#531
Conversation
|
@toddbaert This PR is to move the deprecated method into the |
|
@kylejuliandev I suggest moving all files currently in the Hosting package (under the Why this makes sense
Also, in the Hosting package, we currently have For example: services.ConfigureOptions<FeatureLifecycleStateOptions>(options =>
{
// Optional: configure StartState, StopState, etc.
});All of these options are optional, but this makes it easier and more consistent with typical .NET configuration. |
I am more inclined to move all The dependency tree generally looks like: We should keep only the DI unless we provide only DI extensions. Since we also offer application configuration, I vote to keep the We might need to make changes to the configuration file since I would like to keep the same namespaces we are using now.
Agreed! |
Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com>
* Update Samples App to show how you can work with OpenFeature and Dependency Injection Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com>
* Copy the existing Dependency Injection tests over to a new Hosting.Tests project * Fix issue with the Integration tests Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com>
2a50617 to
211e984
Compare
Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com>
Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com>
Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com>
Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #531 +/- ##
==========================================
+ Coverage 89.73% 90.04% +0.31%
==========================================
Files 64 77 +13
Lines 2523 2873 +350
Branches 295 323 +28
==========================================
+ Hits 2264 2587 +323
- Misses 199 226 +27
Partials 60 60 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@kylejuliandev the code coverage went quite down. You did a copy-paste of the current code without changes? |
Yep, pretty much a copy and paste and update of namespaces and usings. Looking at the code coverage from main: We never produced a report for I was planning on adding some additional unit tests to improve the coverage - if that's ok? |
Go for it! 👍 |
Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com>
Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com>
Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com>
Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com>
Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com>
This PR
AddOpenFeatureThis is technically a breaking change because anyone using both packages in their project, which everyone will be, they will run into issues around resolving the correct extension methods.
Related Issues
Fixes #472
Notes
Follow-up Tasks
How to test