Skip to content

fix(app-server): thread history redaction for remote clients#22178

Merged
owenlin0 merged 1 commit into
mainfrom
owen/thread_resume_redaction
May 11, 2026
Merged

fix(app-server): thread history redaction for remote clients#22178
owenlin0 merged 1 commit into
mainfrom
owen/thread_resume_redaction

Conversation

@owenlin0
Copy link
Copy Markdown
Collaborator

@owenlin0 owenlin0 commented May 11, 2026

Summary

Remote clients can still receive large thread/resume histories when prior turns include MCP tool call payloads or image-generation results. This adds a temporary response-only redaction path for the known remote client names.

Longer term we will move towards fully paginated APIs backed by SQLite.

Changes

  • Redact MCP tool call payload-bearing fields in thread/resume responses for codex_chatgpt_android_remote and codex_chatgpt_ios_remote.
  • Drop imageGeneration items from those thread/resume responses.
  • Keep redaction out of persisted rollout files, thread/read, thread/turns/list, live notifications, and token usage replay.
  • Cover the behavior with app-server helper tests and a v2 resume integration test that checks both remote clients plus a non-target control client.

Testing

  • cargo test -p codex-app-server thread_resume_redaction
  • cargo test -p codex-app-server thread_resume_redacts_payloads_for_chatgpt_remote_clients

@owenlin0 owenlin0 force-pushed the owen/thread_resume_redaction branch from 42a9c79 to 2c84733 Compare May 11, 2026 17:54
@owenlin0 owenlin0 marked this pull request as ready for review May 11, 2026 18:28
@owenlin0 owenlin0 requested a review from euroelessar May 11, 2026 18:29
@owenlin0 owenlin0 merged commit 7bddb30 into main May 11, 2026
26 checks passed
@owenlin0 owenlin0 deleted the owen/thread_resume_redaction branch May 11, 2026 18:45
@github-actions github-actions Bot locked and limited conversation to collaborators May 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants