[5 of 7] Replace OverrideTurnContext with ThreadSettings#22508
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 63a3a26013
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b3105be32a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a46e9baa4b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 34263f13ca
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
etraut-openai
changed the title
etraut-openai
changed the base branch from
main
to
etraut/next-turn-state-input-op-consolidation
etraut-openai
changed the title
etraut-openai
force-pushed
the
etraut/next-turn-state-core
branch
from
b2fa7ac to
9393c26
Compare
etraut-openai
changed the title
etraut-openai
changed the base branch from
etraut/next-turn-state-input-op-consolidation
to
etraut/next-turn-state-remove-override-context
etraut-openai
changed the title
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: de38d2a98b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
etraut-openai
force-pushed
the
etraut/next-turn-state-remove-override-context
branch
from
d6ae36f to
4939645
Compare
etraut-openai
changed the title
**Stack position:** [1 of 7] ## Summary The first three PRs in this stack are a cleanup pass before the actual thread settings API work. Today, core has several overlapping "user input" ops: `UserInput`, `UserInputWithTurnContext`, and `UserTurn`. They differ mostly in how much next-turn state they carry, which makes the later queued thread settings update harder to reason about and review. This PR starts that cleanup by adding the shared `ThreadSettingsOverrides` payload and allowing `Op::UserInput` to carry it. Existing variants remain in place here, so this layer is mostly a behavior-preserving API shape change plus mechanical constructor updates. ## End State After PR3 By the end of PR3, `Op::UserInput` is the only "user input" core op. It can carry optional thread settings overrides for callers that need to update stored defaults with a turn, while callers without updates use empty settings. `Op::UserInputWithTurnContext` and `Op::UserTurn` are deleted. ## End State After PR5 By the end of PR5, core will have only two ops for this area: - `Op::UserInput` for user-input-bearing submissions. - `Op::ThreadSettings` for settings-only updates. ## Stack 1. [1 of 7] [Add thread settings to UserInput](#23080) (this PR) 2. [2 of 7] [Remove UserInputWithTurnContext](#23081) 3. [3 of 7] [Remove UserTurn](#23075) 4. [4 of 7] [Placeholder for OverrideTurnContext cleanup](#23087) 5. [5 of 7] [Replace OverrideTurnContext with ThreadSettings](#22508) 6. [6 of 7] [Add app-server thread settings API](#22509) 7. [7 of 7] [Sync TUI thread settings](#22510)
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ef2278bfdc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
**Stack position:** [2 of 7] ## Summary This PR removes the overlapping `Op::UserInputWithTurnContext` variant now that `Op::UserInput` can carry thread settings overrides directly. ## Stack 1. [1 of 7] [Add thread settings to UserInput](#23080) 2. [2 of 7] [Remove UserInputWithTurnContext](#23081) (this PR) 3. [3 of 7] [Remove UserTurn](#23075) 4. [4 of 7] [Placeholder for OverrideTurnContext cleanup](#23087) 5. [5 of 7] [Replace OverrideTurnContext with ThreadSettings](#22508) 6. [6 of 7] [Add app-server thread settings API](#22509) 7. [7 of 7] [Sync TUI thread settings](#22510)
**Stack position:** [3 of 7] ## Summary This PR finishes the input-op consolidation by moving the remaining `Op::UserTurn` callers onto `Op::UserInput` and deleting `Op::UserTurn`. This touches a lot of files, but it is a low-risk mechanical migration. ## Stack 1. [1 of 7] [Add thread settings to UserInput](#23080) 2. [2 of 7] [Remove UserInputWithTurnContext](#23081) 3. [3 of 7] [Remove UserTurn](#23075) (this PR) 4. [4 of 7] [Placeholder for OverrideTurnContext cleanup](#23087) 5. [5 of 7] [Replace OverrideTurnContext with ThreadSettings](#22508) 6. [6 of 7] [Add app-server thread settings API](#22509) 7. [7 of 7] [Sync TUI thread settings](#22510)
etraut-openai
force-pushed
the
etraut/next-turn-state-core
branch
from
7a091b0 to
9d90b42
Compare
etraut-openai
changed the base branch from
etraut/next-turn-state-remove-override-context
to
main
2 participants
Stack position: [5 of 7]
Summary
This PR adds
Op::ThreadSettings, a queued settings-only update mechanism for changing stored thread settings without starting a new turn. It also removes the legacyOp::OverrideTurnContextin the same layer, so reviewers can see the replacement and deletion together.Changes
Op::ThreadSettingsfor settings-only queued updates.ThreadSettingsAppliedwith the effective thread settings snapshot after core applies an update.OverrideTurnContexttests and callers to the queuedOp::ThreadSettingspath.Op::OverrideTurnContextfrom the core protocol and submission loop.This stack addresses #20656 and #22090.
Stack