[2 of 4] tui: route app and skill enablement through app server#22914
Conversation
etraut-openai
force-pushed
the
etraut/tui-config-app-server-2-catalog-state
branch
from
ff17872 to
6a181fa
Compare
## Why The TUI can run against a remote app server, but several high-traffic settings still persisted by editing the local config file. That sends remote sessions' preference writes to the wrong machine and lets local disk state drift from the app-server-owned config. This is **[1 of 4]** in a stacked series that moves TUI-owned config mutations onto app-server APIs. ## What changed - Added a small TUI helper for typed app-server config writes. - Routed primary interactive preference writes through `config/batchWrite`. - Preserved existing profile scoping for settings that already support `profiles.<profile>.*` overrides. ## Config keys affected - `model` - `model_reasoning_effort` - `personality` - `service_tier` - `plan_mode_reasoning_effort` - `approvals_reviewer` - `notice.fast_default_opt_out` - Profile-scoped equivalents under `profiles.<profile>.*` ## Suggested manual validation - Connect the TUI to a remote app server, change `model` and `model_reasoning_effort`, reconnect, and confirm the remote config retained both values while the local `config.toml` did not change. - Change `personality`, `plan_mode_reasoning_effort`, and the explicit auto-review selection, then reconnect and confirm those choices persist through the app server. - Clear the service tier back to default and confirm `service_tier` is cleared while `notice.fast_default_opt_out = true` is persisted remotely. - Repeat one setting change with an active profile and confirm the write lands under `profiles.<profile>.*`. ## Stack 1. [#22913](#22913) `[1 of 4]` primary settings writes 2. [#22914](#22914) `[2 of 4]` app and skill enablement 3. [#22915](#22915) `[3 of 4]` feature and memory toggles 4. [#22916](#22916) `[4 of 4]` startup and onboarding bookkeeping
etraut-openai
force-pushed
the
etraut/tui-config-app-server-2-catalog-state
branch
from
df4e122 to
fd994c7
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fd994c7a16
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
fcoury-oai
left a comment
fcoury-oai
left a comment
There was a problem hiding this comment.
I had an issue where I start an app-server, connect to it using a different $CODEX_HOME, disable GitHub then restart the client TUI and GitHub is re-enabled.
Disabled GitHub:
Stopped only the client TUI, leaving the app-server running.
Then when I re-start and run /apps and go to GitHub and it shows as enabled:
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 00c31b8f54
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
fcoury-oai
left a comment
fcoury-oai
left a comment
There was a problem hiding this comment.
Re-tested and everything works as expected now. Approved 👍
2 participants
Why
App and skill toggles are user config mutations too. When the TUI is attached to a remote app server, writing those toggles into the local
config.tomlmakes the UI report success without updating the server that actually owns the session.This is [2 of 4] in a stacked series that moves TUI-owned config mutations onto app-server APIs.
What changed
skills/config/write.Config keys affected
apps.<app_id>.enabledapps.<app_id>.disabled_reason[[skills.config]]entries keyed bypath, withenabled = falseused for persisted disablesSuggested manual validation
apps.<app_id>.enabledandapps.<app_id>.disabled_reasonare cleared remotely.[[skills.config]]disable entry appears.Stack
[1 of 4]primary settings writes[2 of 4]app and skill enablement[3 of 4]feature and memory toggles[4 of 4]startup and onboarding bookkeeping