[1 of 7] Add thread settings to UserInput#23080
Merged
Merged
Conversation
This was referenced May 16, 2026
This was referenced May 17, 2026
pakrym-oai
reviewed
May 18, 2026
pakrym-oai
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack position: [1 of 7]
Summary
The first three PRs in this stack are a cleanup pass before the actual thread settings API work.
Today, core has several overlapping "user input" ops:
UserInput,UserInputWithTurnContext, andUserTurn. They differ mostly in how much next-turn state they carry, which makes the later queued thread settings update harder to reason about and review.This PR starts that cleanup by adding the shared
ThreadSettingsOverridespayload and allowingOp::UserInputto carry it. Existing variants remain in place here, so this layer is mostly a behavior-preserving API shape change plus mechanical constructor updates.End State After PR3
By the end of PR3,
Op::UserInputis the only "user input" core op. It can carry optional thread settings overrides for callers that need to update stored defaults with a turn, while callers without updates use empty settings.Op::UserInputWithTurnContextandOp::UserTurnare deleted.End State After PR5
By the end of PR5, core will have only two ops for this area:
Op::UserInputfor user-input-bearing submissions.Op::ThreadSettingsfor settings-only updates.Stack