Skip to content

[1 of 7] Add thread settings to UserInput#23080

Merged
etraut-openai merged 5 commits into
mainfrom
etraut/next-turn-state-user-input-context
May 19, 2026
Merged

[1 of 7] Add thread settings to UserInput#23080
etraut-openai merged 5 commits into
mainfrom
etraut/next-turn-state-user-input-context

Conversation

@etraut-openai
Copy link
Copy Markdown
Collaborator

@etraut-openai etraut-openai commented May 16, 2026

Stack position: [1 of 7]

Summary

The first three PRs in this stack are a cleanup pass before the actual thread settings API work.

Today, core has several overlapping "user input" ops: UserInput, UserInputWithTurnContext, and UserTurn. They differ mostly in how much next-turn state they carry, which makes the later queued thread settings update harder to reason about and review.

This PR starts that cleanup by adding the shared ThreadSettingsOverrides payload and allowing Op::UserInput to carry it. Existing variants remain in place here, so this layer is mostly a behavior-preserving API shape change plus mechanical constructor updates.

End State After PR3

By the end of PR3, Op::UserInput is the only "user input" core op. It can carry optional thread settings overrides for callers that need to update stored defaults with a turn, while callers without updates use empty settings. Op::UserInputWithTurnContext and Op::UserTurn are deleted.

End State After PR5

By the end of PR5, core will have only two ops for this area:

  • Op::UserInput for user-input-bearing submissions.
  • Op::ThreadSettings for settings-only updates.

Stack

  1. [1 of 7] Add thread settings to UserInput (this PR)
  2. [2 of 7] Remove UserInputWithTurnContext
  3. [3 of 7] Remove UserTurn
  4. [4 of 7] Placeholder for OverrideTurnContext cleanup
  5. [5 of 7] Replace OverrideTurnContext with ThreadSettings
  6. [6 of 7] Add app-server thread settings API
  7. [7 of 7] Sync TUI thread settings

Comment thread codex-rs/core/src/session/handlers.rs
@etraut-openai etraut-openai changed the title [1 of 7] Add turn context to UserInput [1 of 7] Add thread settings to UserInput May 18, 2026
@etraut-openai etraut-openai merged commit 84d941d into main May 19, 2026
31 checks passed
@etraut-openai etraut-openai deleted the etraut/next-turn-state-user-input-context branch May 19, 2026 01:48
@github-actions github-actions Bot locked and limited conversation to collaborators May 19, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants