[2 of 7] Remove UserInputWithTurnContext#23081
Merged
etraut-openai merged 2 commits intoMay 19, 2026
Merged
Conversation
This was referenced May 16, 2026
etraut-openai
changed the title
pakrym-oai
approved these changes
May 18, 2026
etraut-openai
added a commit
that referenced
this pull request
May 19, 2026
**Stack position:** [1 of 7] ## Summary The first three PRs in this stack are a cleanup pass before the actual thread settings API work. Today, core has several overlapping "user input" ops: `UserInput`, `UserInputWithTurnContext`, and `UserTurn`. They differ mostly in how much next-turn state they carry, which makes the later queued thread settings update harder to reason about and review. This PR starts that cleanup by adding the shared `ThreadSettingsOverrides` payload and allowing `Op::UserInput` to carry it. Existing variants remain in place here, so this layer is mostly a behavior-preserving API shape change plus mechanical constructor updates. ## End State After PR3 By the end of PR3, `Op::UserInput` is the only "user input" core op. It can carry optional thread settings overrides for callers that need to update stored defaults with a turn, while callers without updates use empty settings. `Op::UserInputWithTurnContext` and `Op::UserTurn` are deleted. ## End State After PR5 By the end of PR5, core will have only two ops for this area: - `Op::UserInput` for user-input-bearing submissions. - `Op::ThreadSettings` for settings-only updates. ## Stack 1. [1 of 7] [Add thread settings to UserInput](#23080) (this PR) 2. [2 of 7] [Remove UserInputWithTurnContext](#23081) 3. [3 of 7] [Remove UserTurn](#23075) 4. [4 of 7] [Placeholder for OverrideTurnContext cleanup](#23087) 5. [5 of 7] [Replace OverrideTurnContext with ThreadSettings](#22508) 6. [6 of 7] [Add app-server thread settings API](#22509) 7. [7 of 7] [Sync TUI thread settings](#22510)
Base automatically changed from
etraut/next-turn-state-user-input-context
to
main
May 19, 2026 01:48
etraut-openai
force-pushed
the
etraut/next-turn-state-remove-user-input-with-context
branch
from
d3052c6 to
6927359
Compare
etraut-openai
deleted the
etraut/next-turn-state-remove-user-input-with-context
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack position: [2 of 7]
Summary
This PR removes the overlapping
Op::UserInputWithTurnContextvariant now thatOp::UserInputcan carry thread settings overrides directly.Stack