TUI: replay in-progress MCP calls as started#23236
Merged
Merged
Conversation
etraut-openai
force-pushed
the
etraut/tui-mcp-replay-status
branch
from
f9996f8 to
d35cf09
Compare
canvrno-oai
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22300.
Summary
MCP tool calls can appear in thread history while still in progress. During replay,
handle_thread_itemrouted everyThreadItem::McpToolCallto the completion handler, so an in-progress item with no result or error was rendered asMCP tool call completed without a result.This updates replay handling to mirror command executions:
InProgressMCP calls go throughon_mcp_tool_call_started, while completed and failed calls continue through the completion path.Validation
cargo test -p codex-tui replayed_in_progress_mcp_tool_call_stays_active