feat(permissions): apply inherited profiles at runtime#23705
Merged
bolinfest merged 2 commits intoMay 20, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fdf7559323
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
bolinfest
reviewed
May 20, 2026
Co-authored-by: Codex noreply@openai.com
Co-authored-by: Codex noreply@openai.com
fdf7559 to
b620d33
Compare
7155129
into
codex/permissions-profile-extends
30 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack
This PR is stacked on #22270. Review #22270 first for the config-level
extendsresolver and merge semantics; this follow-up contains the runtime and protocol wiring on top of that foundation.Why
The resolver in #22270 makes inherited permission profiles well-defined in config, but selected profiles still need to flow through runtime permission compilation, network-proxy selection, and the active-profile metadata exposed to clients. This PR keeps that integration separate from the inheritance rules themselves so each diff has a narrower review surface.
What changed
:read-onlyand:workspace.extendsmetadata on the active permission profile while the resolved permissions drive runtime behavior.extendsfield.Validation
Run on the full inheritance stack before the PR split:
cargo test -p codex-configcargo test -p codex-core permissions_profiles_cargo test -p codex-core selected_network_from_tables_cargo test -p codex-core default_permissions_profile_can_extend_builtin_workspace