This repository was archived by the owner on Feb 18, 2025. It is now read-only.
supporting prefer_not promotion rule#247
Merged
Merged
Conversation
added 6 commits
July 30, 2017 10:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Up till now these promotion rules were supported:
prefer: promote if possibleneutralmust_not: never even participates in promotion process.We now add
prefer_not:neutral > prefer_not > must_notA
prefer_notserver has nothing special about it; it is valid. It contains good data, but we wish not to promote it.As an example, perhaps this is in particular a weak box, or some
AWSbox that is heavily used for something else.However, if a master dies, and such box turns to be most up to date, then by all means we can use it in the promotion flow. For example, we can discretely promote it, let other boxes catch up, then, if promote a
preferbox (aka candidate) or even aneutralbox on top of it.So basically it's similar to
neutralin essence: nothing special about it, except we'd rather haveneutralpromoted instead of aprefer_not.