Skip to content
This repository was archived by the owner on Feb 18, 2025. It is now read-only.

support SkipOrchestratorDatabaseUpdate#85

Merged
shlomi-noach merged 8 commits into
masterfrom
skip-orchestrator-database-update
Mar 6, 2017
Merged

support SkipOrchestratorDatabaseUpdate#85
shlomi-noach merged 8 commits into
masterfrom
skip-orchestrator-database-update

Conversation

@shlomi-noach
Copy link
Copy Markdown
Collaborator

Storyline: #84

This PR re-introduced the SkipOrchestratorDatabaseUpdate (bool) configuration parameter.

When running multiple versions of orcehstrator, this can be useful: orchestrator marks the backend database schema with last known deployed version. Whenever an orchestrator instance runs, that is of a different version, database schema gets rebuilt. With this flag one can control the identity of the orchestrator hosts that dictate database schema.

Normally, users would not use this flag. On very large deployments this would prove useful.

cc @sjmudd

@sjmudd
Copy link
Copy Markdown
Collaborator

sjmudd commented Feb 22, 2017

Looks good to me. Thanks.

@shlomi-noach
Copy link
Copy Markdown
Collaborator Author

Also added PanicIfDifferentDatabaseDeploy -- bail out if db version is not what the app expects. This complements SkipOrchestratorDatabaseUpdate's behavior.

cc @sjmudd

…/orchestrator into skip-orchestrator-database-update
@sjmudd
Copy link
Copy Markdown
Collaborator

sjmudd commented Feb 25, 2017

Excellent. Thanks for the PanicIfDifferentDatabaseDeploy. Most helpful. Will keep out of date clients "out of harms way" which is good.

@shlomi-noach shlomi-noach merged commit 63d5a7f into master Mar 6, 2017
@shlomi-noach shlomi-noach deleted the skip-orchestrator-database-update branch March 6, 2017 06:38
@shlomi-noach
Copy link
Copy Markdown
Collaborator Author

Actually I was wrong and didn't look carefully at the code. SkipOrchestratorDatabaseUpdate isn't really needed:
The orchestrator backend DB records all db deployments, not just the last one. It's OK (assuming migrations are backwards compatible) to have multiple clients connecting with different versions: each orchestrator will notice its own version is already deployed and will not give it another try.

@sjmudd The Great Exodus of Variables is an effort to eliminate unneeded variables. I'm in favor of throwing away SkipOrchestratorDatabaseUpdate (again... 😛 ). What do you think?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants