Skip to content

Commit e67725c

Browse files
committed
contrib: remove deprecated memfd-bind binary
This was a really ugly hack to try to reduce the impact of our original set of CVE-2019-5736 mitigations, but unfortunately had too many caveats to its use to ever be really useful. In addition, it was completely obsoleted by the migration to using an detached overlayfs mount in commit 515f09f ("dmz: use overlayfs to write-protect /proc/self/exe if possible"). Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
1 parent 625ef53 commit e67725c

6 files changed

Lines changed: 6 additions & 338 deletions

File tree

.gitignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
vendor/pkg
22
/runc
33
/runc-*
4-
/contrib/cmd/memfd-bind/memfd-bind
54
/tests/cmd/_bin
65
man/man8
76
release

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
4141
- `libcontainer/devices.Type`
4242
- `libcontainer/devices.Rule`
4343

44+
### Removed ###
45+
- The `memfd-bind` helper binary has been removed, as it has never been
46+
particularly useful and was completely obsoleted by the changes to
47+
`/proc/self/exe` sealing we introduced in runc [1.2.0][]. (#5141)
48+
4449
## [1.4.0] - 2025-11-27
4550

4651
> 路漫漫其修远兮,吾将上下而求索!

Makefile

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -77,11 +77,7 @@ runc-bin:
7777
$(GO_BUILD) -o runc .
7878

7979
.PHONY: all
80-
all: runc memfd-bind
81-
82-
.PHONY: memfd-bind
83-
memfd-bind:
84-
$(GO_BUILD) -o contrib/cmd/$@/$@ ./contrib/cmd/$@
80+
all: runc
8581

8682
TESTBINDIR := tests/cmd/_bin
8783
$(TESTBINDIR):
@@ -96,7 +92,6 @@ $(TESTBINS): $(TESTBINDIR)
9692
.PHONY: clean
9793
clean:
9894
rm -f runc runc-*
99-
rm -f contrib/cmd/memfd-bind/memfd-bind
10095
rm -fr $(TESTBINDIR)
10196
sudo rm -rf release
10297
rm -rf man/man8

contrib/cmd/memfd-bind/README.md

Lines changed: 0 additions & 69 deletions
This file was deleted.

contrib/cmd/memfd-bind/memfd-bind.go

Lines changed: 0 additions & 251 deletions
This file was deleted.

contrib/cmd/memfd-bind/memfd-bind@.service

Lines changed: 0 additions & 11 deletions
This file was deleted.

0 commit comments

Comments
 (0)