build: update extract_translations target by farhan · Pull Request #35 · openedx/xblocks-extra

farhan · 2026-05-04T16:57:34Z

Study the parent story for the implementation of this PR: openedx/xblocks-core#241

Relevant openedx-translations PR: openedx/openedx-translations#72135

Reference studied code for the translations work: https://github.com/openedx/FeedbackXBlock/blob/master/Makefile#L78

How to test:

Create python virtual environment
pip install edx-i18n-tools
Run make extract_translations at root of repository

Translations should be created as per screen shot.

codecov · 2026-05-04T17:39:00Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.80%. Comparing base (c09eb76) to head (e229557).

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #35   +/-   ##
=======================================
  Coverage   79.80%   79.80%           
=======================================
  Files          41       41           
  Lines        1139     1139           
  Branches       75       75           
=======================================
  Hits          909      909           
  Misses        203      203           
  Partials       27       27

Flag	Coverage Δ
unittests	`79.80% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

- Update it as per requirement of openedx-platform https://github.com/openedx/openedx-platform/blob/master/openedx/core/djangoapps/plugins/i18n_api.py#L125

Copilot

Pull request overview

Updates the repository’s localization extraction workflow to align with the newer openedx-translations expectations by changing where extracted .po files are written and tightening gitignore patterns for locale artifacts.

Changes:

Add REPO_ROOT and update XBlock discovery to use it.
Rewrite extract_translations to extract per-XBlock catalogs, merge djangojs.po into django.po, and copy results into <module_name>/conf/locale/....
Update .gitignore to ignore all files under **/conf/locale/**/LC_MESSAGES/* (instead of blanket *.po).

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 3 comments.

File	Description
Makefile	Reworks `extract_translations` to generate/copy per-module `django.po` files and adds `REPO_ROOT` usage.
.gitignore	Narrows ignore rules from all `*.po` to locale-message directories.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

 .PHONY: validate_translations pull_translations push_translations install_transifex_client


+REPO_ROOT := $(shell pwd)


farhan · 2026-05-07T11:50:00Z

+		mkdir -p $(REPO_ROOT)/$$module_name/$(EXTRACT_DIR); \
+		cp $$xblock/$(EXTRACT_DIR)/django.po $(REPO_ROOT)/$$module_name/$(EXTRACT_DIR)/django.po; \


not helpful in our context

irfanuddinahmad · 2026-05-07T14:24:48Z

Missing pull_translations (OEP-58 distribution side)

PR removes the old i18n_tool transifex pull based pull_translations but adds no replacement. Without it, translated files from openedx-translations never land in src/<module>/conf/locale/<lang>/ at runtime.

Add this to the Makefile:

pull_translations: ## pull translations from openedx-translations via atlas
	atlas pull \
	    translations/xblocks-extra/audio/conf/locale:src/audio/conf/locale \
	    translations/xblocks-extra/feedback/conf/locale:src/feedback/conf/locale \
	    translations/xblocks-extra/imagemodal/conf/locale:src/imagemodal/conf/locale \
	    translations/xblocks-extra/qualtricssurvey/conf/locale:src/qualtricssurvey/conf/locale \
	    translations/xblocks-extra/sql_grader/conf/locale:src/sql_grader/conf/locale \
	    translations/xblocks-extra/submit_and_compare/conf/locale:src/submit_and_compare/conf/locale
	@for xblock in $(XBLOCKS); do \
	    cd $$xblock && django-admin compilemessages; \
	done

Also note: edx-platform's pull_xblock_translations management command pulls XBlock translations via package i18n entry points — each consolidated xblock's package metadata will need to declare the new translations/xblocks-extra/<module>/conf/locale path so the platform can find them.

farhan · 2026-05-07T14:59:38Z

Missing pull_translations (OEP-58 distribution side)

PR removes the old i18n_tool transifex pull based pull_translations but adds no replacement. Without it, translated files from openedx-translations never land in src/<module>/conf/locale/<lang>/ at runtime.

Add this to the Makefile:
pull_translations: ## pull translations from openedx-translations via atlas
	atlas pull \
	    translations/xblocks-extra/audio/conf/locale:src/audio/conf/locale \
	    translations/xblocks-extra/feedback/conf/locale:src/feedback/conf/locale \
	    translations/xblocks-extra/imagemodal/conf/locale:src/imagemodal/conf/locale \
	    translations/xblocks-extra/qualtricssurvey/conf/locale:src/qualtricssurvey/conf/locale \
	    translations/xblocks-extra/sql_grader/conf/locale:src/sql_grader/conf/locale \
	    translations/xblocks-extra/submit_and_compare/conf/locale:src/submit_and_compare/conf/locale
	@for xblock in $(XBLOCKS); do \
	    cd $$xblock && django-admin compilemessages; \
	done
Also note: edx-platform's pull_xblock_translations management command pulls XBlock translations via package i18n entry points — each consolidated xblock's package metadata will need to declare the new translations/xblocks-extra/<module>/conf/locale path so the platform can find them.

I didn't find the place where this pull_translations target is required, can you please refer me

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

irfanuddinahmad · 2026-05-07T16:20:41Z

Missing pull_translations (OEP-58 distribution side)
PR removes the old i18n_tool transifex pull based pull_translations but adds no replacement. Without it, translated files from openedx-translations never land in src/<module>/conf/locale/<lang>/ at runtime.
Add this to the Makefile:
pull_translations: ## pull translations from openedx-translations via atlas
	atlas pull \
	    translations/xblocks-extra/audio/conf/locale:src/audio/conf/locale \
	    translations/xblocks-extra/feedback/conf/locale:src/feedback/conf/locale \
	    translations/xblocks-extra/imagemodal/conf/locale:src/imagemodal/conf/locale \
	    translations/xblocks-extra/qualtricssurvey/conf/locale:src/qualtricssurvey/conf/locale \
	    translations/xblocks-extra/sql_grader/conf/locale:src/sql_grader/conf/locale \
	    translations/xblocks-extra/submit_and_compare/conf/locale:src/submit_and_compare/conf/locale
	@for xblock in $(XBLOCKS); do \
	    cd $$xblock && django-admin compilemessages; \
	done
Also note: edx-platform's pull_xblock_translations management command pulls XBlock translations via package i18n entry points — each consolidated xblock's package metadata will need to declare the new translations/xblocks-extra/<module>/conf/locale path so the platform can find them.
I didn't find the place where this pull_translations target is required, can you please refer me

@farhan it is a new pull_translations target using atlas, with the correct destination paths

farhan · 2026-05-08T11:31:22Z

@farhan it is a new pull_translations target using atlas, with the correct destination paths

As per my study pull_translations target is not required in the translations flow of openedx-translations

Translations targets were added in xblocks-extra just for the testing purpose and weren't fully tested.

As per claude

How `openedx-translations` pull the translations:

transifex.yml — the main configuration file

This is the core file that tells Transifex what to sync. It maps source files to
translation output paths for every component. For example, for edx-platform (lines
94–101):

edx-platform

filter_type: dir
file_format: PO
source_language: en
source_file_dir: translations/edx-platform/conf/locale/en/
mode: onlyreviewed
translation_files_expression: 'translations/edx-platform/conf/locale//'

Key fields:

mode: onlyreviewed — only pulls translations that have been reviewed/approved in
Transifex

source_file_dir / source_file — where English source strings live in the repo

translation_files_expression — where Transifex deposits the translated files (with
as a placeholder)

.github/workflows/automerge-transifex-app-prs.yml

Transifex's GitHub App (transifex-integration) opens PRs into this repo whenever
translations are updated. This workflow automatically merges those PRs (rebase
merge) when the PR author matches the configured Transifex bot actor (verified via
TRANSIFEX_APP_ACTOR_NAME and TRANSIFEX_APP_ACTOR_ID secrets).

The flow is:

Source strings are pushed to Transifex (via extract-translation-source-files.yml)

Translators review and approve strings in Transifex

Transifex's GitHub App opens a PR with the translated .po/.json files into this
repo

The automerge workflow auto-merges those PRs

transifex configs for xblocks-extra has been done in this PR

irfanuddinahmad · 2026-05-08T14:52:18Z

@farhan you are right — pull_translations is not required here. Translations flow from openedx-translations to running environments via Tutor/atlas at deploy time, not through a target in this repo. Withdrawing that suggestion.

One narrower point remains: each consolidated XBlock's Python package will need to declare its i18n entry point pointing to the new translations/xblocks-extra/<module>/conf/locale path, so that edx-platform's pull_xblock_translations management command can locate translations correctly. That's a packaging concern, not a Makefile one, and can be tracked separately.

build: update extract_translations target

d4007d7

farhan added 2 commits May 5, 2026 11:36

build: update extract_translations target

2756d9b

- Update it as per requirement of openedx-platform https://github.com/openedx/openedx-platform/blob/master/openedx/core/djangoapps/plugins/i18n_api.py#L125

build!: remove extra translations target

1e74ea1

farhan force-pushed the farhan/fix-translations branch from 88b27aa to 1e74ea1 Compare May 5, 2026 07:14

farhan mentioned this pull request May 5, 2026

Adds translation paths for xblocks-extra consolidated blocks openedx/openedx-translations#72135

Open

farhan requested review from brian-smith-tcril and feanil May 5, 2026 14:51

farhan added this to Aximprovements Team May 6, 2026

farhan moved this to 👀 In review in Aximprovements Team May 6, 2026

farhan self-assigned this May 6, 2026

farhan mentioned this pull request May 6, 2026

Switch to top-level Python packages openedx/xblocks-core#237

Open

irfanuddinahmad requested a review from Copilot May 7, 2026 08:13

Copilot started reviewing on behalf of irfanuddinahmad May 7, 2026 08:13 View session

Copilot AI reviewed May 7, 2026

View reviewed changes

chore: apply if condition while copying the file

5dd44ef

farhan requested a review from Copilot May 7, 2026 15:48

Copilot AI reviewed May 7, 2026

View reviewed changes

Copilot started reviewing on behalf of farhan May 7, 2026 19:14 View session

chore: move rahter than copy the *.po file

64fda5a

farhan requested a review from irfanuddinahmad May 8, 2026 13:49

irfanuddinahmad approved these changes May 8, 2026

View reviewed changes

salman2013 requested changes May 8, 2026

View reviewed changes

Comment thread Makefile Outdated

chore: udpate make file targets declaraion

e229557

salman2013 approved these changes May 8, 2026

View reviewed changes

farhan merged commit e185cd8 into main May 8, 2026
7 checks passed

farhan deleted the farhan/fix-translations branch May 8, 2026 15:16

github-project-automation Bot moved this from 👀 In review to ✅ Done in Aximprovements Team May 8, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build: update extract_translations target#35

build: update extract_translations target#35
farhan merged 6 commits intomainfrom
farhan/fix-translations

farhan commented May 4, 2026 •

edited

Loading

Uh oh!

codecov Bot commented May 4, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

farhan May 7, 2026 •

edited

Loading

Uh oh!

Uh oh!

irfanuddinahmad commented May 7, 2026

Uh oh!

farhan commented May 7, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

irfanuddinahmad commented May 7, 2026

Uh oh!

farhan commented May 8, 2026

edx-platform

Uh oh!

irfanuddinahmad commented May 8, 2026

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		.PHONY: validate_translations pull_translations push_translations install_transifex_client


		REPO_ROOT := $(shell pwd)

		mkdir -p $(REPO_ROOT)/$$module_name/$(EXTRACT_DIR); \
		cp $$xblock/$(EXTRACT_DIR)/django.po $(REPO_ROOT)/$$module_name/$(EXTRACT_DIR)/django.po; \

Conversation

farhan commented May 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to test:

Uh oh!

codecov Bot commented May 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

farhan May 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

irfanuddinahmad commented May 7, 2026

Uh oh!

farhan commented May 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

irfanuddinahmad commented May 7, 2026

Uh oh!

farhan commented May 8, 2026

How openedx-translations pull the translations:

edx-platform

Uh oh!

irfanuddinahmad commented May 8, 2026

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

farhan commented May 4, 2026 •

edited

Loading

codecov Bot commented May 4, 2026 •

edited

Loading

farhan May 7, 2026 •

edited

Loading

farhan commented May 7, 2026 •

edited

Loading

How `openedx-translations` pull the translations: