@@ -141,7 +141,7 @@ following rules before you submit a pull request:
141141
142142- If your pull request addresses an issue, please use the pull request title
143143 to describe the issue and mention the issue number in the pull request description. This will make sure a link back to the original issue is
144- created.
144+ created. Make sure the title is descriptive enough to understand what the pull request does!
145145
146146- An incomplete contribution -- where you expect to do more work before
147147 receiving a full review -- should be submitted as a ` draft ` . These may be useful
@@ -174,8 +174,6 @@ following rules before you submit a pull request:
174174 For the Bug-fixes case, at the time of the PR, this tests should fail for
175175 the code base in develop and pass for the PR code.
176176
177- - Add your changes to the changelog in the file doc/progress.rst.
178-
179177 - If any source file is being added to the repository, please add the BSD 3-Clause license to it.
180178
181179
@@ -201,17 +199,12 @@ Make sure your code has good unittest **coverage** (at least 80%).
201199
202200Pre-commit is used for various style checking and code formatting.
203201Before each commit, it will automatically run:
204- - [black ](https://black.readthedocs.io/en/stable/ ) a code formatter.
202+ - [ruff ](https://docs.astral.sh/ruff/ ) a code formatter and linter .
205203 This will automatically format your code.
206204 Make sure to take a second look after any formatting takes place,
207205 if the resulting code is very bloated, consider a (small) refactor.
208- * note* : If Black reformats your code, the commit will automatically be aborted.
209- Make sure to add the formatted files (back) to your commit after checking them.
210206 - [mypy](https://mypy.readthedocs.io/en/stable/) a static type checker.
211207 In particular, make sure each function you work on has type hints.
212- - [flake8](https://flake8.pycqa.org/en/latest/index.html) style guide enforcement.
213- Almost all of the black-formatted code should automatically pass this check,
214- but make sure to make adjustments if it does fail.
215208
216209If you want to run the pre-commit tests without doing a commit, run:
217210` ` ` bash
@@ -224,23 +217,6 @@ $ pre-commit run --all-files
224217Make sure to do this at least once before your first commit to check your setup works.
225218
226219Executing a specific unit test can be done by specifying the module, test case, and test.
227- To obtain a hierarchical list of all tests, run
228-
229- ` ` ` bash
230- $ pytest --collect-only
231-
232- < Module ' tests/test_datasets/test_dataset.py' >
233- < UnitTestCase ' OpenMLDatasetTest' >
234- < TestCaseFunction ' test_dataset_format_constructor' >
235- < TestCaseFunction ' test_get_data' >
236- < TestCaseFunction ' test_get_data_rowid_and_ignore_and_target' >
237- < TestCaseFunction ' test_get_data_with_ignore_attributes' >
238- < TestCaseFunction ' test_get_data_with_rowid' >
239- < TestCaseFunction ' test_get_data_with_target' >
240- < UnitTestCase ' OpenMLDatasetTestOnTestServer' >
241- < TestCaseFunction ' test_tagging' >
242- ` ` `
243-
244220You may then run a specific module, test case, or unit test respectively:
245221` ` ` bash
246222 $ pytest tests/test_datasets/test_dataset.py
@@ -271,7 +247,7 @@ information.
271247
272248For building the documentation, you will need to install a few additional dependencies:
273249` ` ` bash
274- $ pip install -e .[docs]
250+ $ pip install -e .[examples, docs]
275251` ` `
276252When dependencies are installed, run
277253` ` ` bash
0 commit comments