remove chaching part

Signed-off-by: Omswastik-11 <omswastikpanda11@gmail.com>

Author: Omswastik-11

openml/_api/resources/base.py

@@ -38,15 +38,13 @@ class FlowsAPI(ResourceAPI, ABC):
     def get(
         self,
         flow_id: int,
-        *,
-        return_response: bool = False,
-    ) -> OpenMLFlow | tuple[OpenMLFlow, Response]: ...
+    ) -> OpenMLFlow: ...
 
     @abstractmethod
     def exists(self, name: str, external_version: str) -> int | bool: ...
 
     @abstractmethod
-    def list_page(
+    def list(
         self,
         *,
         limit: int | None = None,

openml/_api/resources/flows.py

@@ -1,6 +1,6 @@
 from __future__ import annotations
 
-from typing import TYPE_CHECKING, Any
+from typing import Any
 
 import pandas as pd
 import requests
@@ -9,17 +9,12 @@
 from openml._api.resources.base import FlowsAPI
 from openml.flows.flow import OpenMLFlow
 
-if TYPE_CHECKING:
-    from requests import Response
-
 
 class FlowsV1(FlowsAPI):
     def get(
         self,
         flow_id: int,
-        *,
-        return_response: bool = False,
-    ) -> OpenMLFlow | tuple[OpenMLFlow, Response]:
+    ) -> OpenMLFlow:
         """Get a flow from the OpenML server.
 
         Parameters
@@ -36,10 +31,7 @@ def get(
         """
         response = self._http.get(f"flow/{flow_id}")
         flow_xml = response.text
-        flow = OpenMLFlow._from_dict(xmltodict.parse(flow_xml))
-        if return_response:
-            return flow, response
-        return flow
+        return OpenMLFlow._from_dict(xmltodict.parse(flow_xml))
 
     def exists(self, name: str, external_version: str) -> int | bool:
         """Check if a flow exists on the OpenML server.
@@ -68,7 +60,7 @@ def exists(self, name: str, external_version: str) -> int | bool:
         flow_id = int(result_dict["oml:flow_exists"]["oml:id"])
         return flow_id if flow_id > 0 else False
 
-    def list_page(
+    def list(
         self,
         *,
         limit: int | None = None,
@@ -181,9 +173,7 @@ class FlowsV2(FlowsAPI):
     def get(
         self,
         flow_id: int,
-        *,
-        return_response: bool = False,
-    ) -> OpenMLFlow | tuple[OpenMLFlow, Response]:
+    ) -> OpenMLFlow:
         """Get a flow from the OpenML v2 server.
 
         Parameters
@@ -203,11 +193,7 @@ def get(
 
         # Convert v2 JSON to v1-compatible dict for OpenMLFlow._from_dict()
         flow_dict = self._convert_v2_to_v1_format(flow_json)
-        flow = OpenMLFlow._from_dict(flow_dict)
-
-        if return_response:
-            return flow, response
-        return flow
+        return OpenMLFlow._from_dict(flow_dict)
 
     def exists(self, name: str, external_version: str) -> int | bool:
         """Check if a flow exists on the OpenML v2 server.
@@ -238,15 +224,15 @@ def exists(self, name: str, external_version: str) -> int | bool:
             # v2 returns 404 when flow doesn't exist
             return False
 
-    def list_page(
+    def list(
         self,
         *,
         limit: int | None = None,
         offset: int | None = None,
         tag: str | None = None,
         uploader: str | None = None,
     ) -> pd.DataFrame:
-        raise NotImplementedError("GET /flows (list) not yet implemented in v2 server")
+        raise NotImplementedError("flows (list) not yet implemented in v2 server")
 
     def create(self, flow: OpenMLFlow) -> OpenMLFlow:
         raise NotImplementedError("POST /flows (create) not yet implemented in v2 server")

openml/flows/functions.py

@@ -121,19 +121,7 @@ def _get_flow_description(flow_id: int) -> OpenMLFlow:
     except OpenMLCacheException:
         from openml._api import api_context
 
-        xml_file = (
-            openml.utils._create_cache_directory_for_id(FLOWS_CACHE_DIR_NAME, flow_id) / "flow.xml"
-        )
-        result = api_context.backend.flows.get(flow_id, return_response=True)
-
-        if isinstance(result, tuple):
-            flow, response = result
-            with xml_file.open("w", encoding="utf8") as fh:
-                fh.write(response.text)
-        else:
-            flow = result
-
-        return flow
+        return api_context.backend.flows.get(flow_id)
 
 
 def list_flows(
@@ -169,7 +157,9 @@ def list_flows(
             - external version
             - uploader
     """
-    listing_call = partial(_list_flows, tag=tag, uploader=uploader)
+    from openml._api import api_context
+
+    listing_call = partial(api_context.backend.flows.list, tag=tag, uploader=uploader)
     batches = openml.utils._list_all(listing_call, offset=offset, limit=size)
     if len(batches) == 0:
         return pd.DataFrame()
@@ -196,7 +186,7 @@ def _list_flows(limit: int, offset: int, **kwargs: Any) -> pd.DataFrame:
     """
     from openml._api import api_context
 
-    return api_context.backend.flows.list_page(
+    return api_context.backend.flows.list(
         limit=limit,
         offset=offset,
         tag=kwargs.get("tag"),
@@ -323,9 +313,7 @@ def __list_flows(api_call: str) -> pd.DataFrame:
         # Silently continue if parsing fails; all params default to None
         pass
 
-    return api_context.backend.flows.list_page(
-        limit=limit, offset=offset, tag=tag, uploader=uploader
-    )
+    return api_context.backend.flows.list(limit=limit, offset=offset, tag=tag, uploader=uploader)
 
 
 def _check_flow_for_server_id(flow: OpenMLFlow) -> None:

tests/test_flows/test_flow_migration.py

@@ -61,20 +61,19 @@ def test_list_flows_delegates_to_backend(monkeypatch):
         "uploader": ["u", "u"],
     }).set_index("id")
 
-    def fake_list_page(limit: int | None, offset: int | None, tag: str | None, uploader: str | None):
+    def fake_list(limit: int | None, offset: int | None, tag: str | None, uploader: str | None):
         calls.append((limit or 0, offset or 0, tag, uploader))
         return df
 
-    monkeypatch.setattr(api_context.backend.flows, "list_page", fake_list_page)
-
+    monkeypatch.setattr(api_context.backend.flows, "list", fake_list)
     result = openml.flows.list_flows(offset=0, size=5, tag="t", uploader="u")
 
     assert result.equals(df)
     # _list_all passes batch_size as limit; expect one call
     assert calls == [(5, 0, "t", "u")]
 
 
-def test_get_flow_description_fetches_and_caches(monkeypatch, tmp_path, dummy_flow):
+def test_get_flow_description_fetches_on_cache_miss(monkeypatch, tmp_path, dummy_flow):
     from openml._api import api_context
 
     # Force cache miss
@@ -83,32 +82,14 @@ def raise_cache(_fid: int) -> None:
 
     monkeypatch.setattr(flow_functions, "_get_cached_flow", raise_cache)
 
-    def fake_cache_dir(_key: str, id_: int):
-        path = tmp_path / str(id_)
-        path.mkdir(parents=True, exist_ok=True)
-        return path
-
-    monkeypatch.setattr(openml.utils, "_create_cache_directory_for_id", fake_cache_dir)
-
-    xml_text = "<oml:flow>test</oml:flow>"
-    response = requests.Response()
-    response.status_code = 200
-    response._content = xml_text.encode()
-
-    def fake_get(flow_id: int, *, return_response: bool = False):
-        if return_response:
-            return dummy_flow, response
+    def fake_get(flow_id: int):
         return dummy_flow
 
     monkeypatch.setattr(api_context.backend.flows, "get", fake_get)
 
     flow = flow_functions._get_flow_description(123)
 
     assert flow is dummy_flow
-    cached = (tmp_path / "123" / "flow.xml").read_text()
-    assert cached == xml_text
-    cached = (tmp_path / "123" / "flow.xml").read_text()
-    assert cached == xml_text
 
 
 def test_delete_flow_delegates_to_backend(monkeypatch):