Skip to content

pathological events: bump KMS ScalingReplicaSet threshold to 150#31209

Open
gangwgr wants to merge 1 commit into
openshift:mainfrom
gangwgr:fix-kms-scaling-threshold
Open

pathological events: bump KMS ScalingReplicaSet threshold to 150#31209
gangwgr wants to merge 1 commit into
openshift:mainfrom
gangwgr:fix-kms-scaling-threshold

Conversation

@gangwgr
Copy link
Copy Markdown
Contributor

@gangwgr gangwgr commented May 22, 2026

The KMS encryption tests trigger cascading rollouts across openshift-apiserver and openshift-oauth-apiserver. The previous threshold of 100 was exceeded in CI (observed 106 events), causing spurious pathological event failures. Bump to 150 to provide adequate headroom.

Summary by CodeRabbit

  • Chores
    • Updated event validation thresholds in KMS encryption test scenarios to accommodate a higher frequency of scaling-related events, improving test reliability during rollouts.

The KMS encryption tests trigger cascading rollouts across
openshift-apiserver and openshift-oauth-apiserver. The previous
threshold of 100 was exceeded in CI (observed 106 events),
causing spurious pathological event failures. Bump to 150 to
provide adequate headroom.
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 22, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 59d62718-a1be-4855-8e54-acadca3759df

📥 Commits

Reviewing files that changed from the base of the PR and between 30f8325 and e5cce4a.

📒 Files selected for processing (1)
  • pkg/monitortestlibrary/pathologicaleventlibrary/duplicated_event_patterns.go

Walkthrough

This pull request increases the repeat threshold tolerance for ScalingReplicaSet events in the KMS-encryption test matcher. The change updates both the comment documentation and the repeatThresholdOverride value to allow more repeated events during test execution.

Changes

KMS Encryption ScalingReplicaSet Matcher

Layer / File(s) Summary
Increase ScalingReplicaSet repeat threshold for KMS encryption tests
pkg/monitortestlibrary/pathologicaleventlibrary/duplicated_event_patterns.go
Comment updated to reflect new observed range, and repeatThresholdOverride increased for newKMSEncryptionTestScalingReplicaSetMatcher to tolerate higher repeat counts for ScalingReplicaSet events.

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: bumping a KMS ScalingReplicaSet threshold value to 150, which matches the file modification in duplicated_event_patterns.go.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR contains no Ginkgo tests (It/Describe/Context/When declarations). Changes are limited to library code updating KMS event matcher thresholds and comments in non-test files.
Test Structure And Quality ✅ Passed PR modifies duplicated_event_patterns.go, a library file with matcher configurations, not Ginkgo test code. The custom check targeting Ginkgo tests is inapplicable.
Microshift Test Compatibility ✅ Passed This PR does not add any new Ginkgo e2e tests. It only modifies event matcher configuration thresholds in a library file. The check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR modifies only pathological event library thresholds, not Ginkgo e2e tests. No new tests added; check for multi-node assumptions is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies only test library thresholds in KMS event detection, not deployment manifests, operators, or controllers. No scheduling constraints or topology configurations introduced.
Ote Binary Stdout Contract ✅ Passed This is a library package file with no main(), init(), TestMain(), or suite setup code. The change updates only a threshold value and comment. No stdout writes detected anywhere in the file.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR does not add new Ginkgo e2e tests - it modifies pathological event matcher thresholds only. Custom check applies only to new test declarations.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 22, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gangwgr
Once this PR has been reviewed and has the lgtm label, please assign neisw for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot requested review from deads2k and p0lyn0mial May 22, 2026 07:21
@openshift-ci openshift-ci Bot added the ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review label May 22, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 22, 2026

@gangwgr: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-ovn e5cce4a link true /test e2e-vsphere-ovn
ci/prow/e2e-vsphere-ovn-upi e5cce4a link true /test e2e-vsphere-ovn-upi

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant