don't create a cinder type if already it exist

Avoid Puppet warnings by checking if a volume type exist before trying
to actually create it.

Closes-bug #1319857
Signed-off-by: Emilien Macchi <emilien.macchi@enovance.com>

Change-Id: Ib31db545d1d761fc6abed0a42dd7ae8e6cc0f25f
(cherry picked from commit 1569926)

Author: Emilien Macchi

manifests/type.pp

@@ -43,6 +43,7 @@
   exec {"cinder type-create ${volume_name}":
     path        => '/usr/bin',
     command     => "cinder type-create ${volume_name}",
+    unless      => "cinder type-list | grep ${volume_name}",
     environment => [
       "OS_TENANT_NAME=${os_tenant_name}",
       "OS_USERNAME=${os_username}",
@@ -64,4 +65,4 @@
       os_auth_url     => $os_auth_url,
     }
   }
-}
+}

spec/defines/cinder_type_spec.rb

@@ -24,6 +24,7 @@
         'OS_USERNAME=admin',
         'OS_PASSWORD=asdf',
         'OS_AUTH_URL=http://127.127.127.1:5000/v2.0/'],
+      :unless  => 'cinder type-list | grep hippo',
       :require => 'Package[python-cinderclient]')
     should contain_exec('cinder type-key hippo set volume_backend_name=name1')
     should contain_exec('cinder type-key hippo set volume_backend_name=name2')