Skip to content

Commit 4276a55

Browse files
fix dns error (#1613)
1 parent 696008d commit 4276a55

1 file changed

Lines changed: 5 additions & 2 deletions

File tree

apps/checker/handlers/dns.go

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ func (h Handler) DNSHandler(c *gin.Context) {
135135
log.Ctx(ctx).Debug().Msgf("evaluating %d dns assertions", len(req.RawAssertions))
136136
isSuccessful, err = EvaluateDNSAssertions(req.RawAssertions, response)
137137
if err != nil {
138-
return nil, backoff.Permanent(err)
138+
return response, backoff.Permanent(err)
139139
}
140140
}
141141
if !isSuccessful && called < retry {
@@ -150,7 +150,9 @@ func (h Handler) DNSHandler(c *gin.Context) {
150150

151151
result, err := backoff.Retry(ctx, op, backoff.WithBackOff(backoff.NewExponentialBackOff()), backoff.WithMaxTries(uint(retry)))
152152
data.Latency = latency
153-
data.Records = FormatDNSResult(result)
153+
if result != nil {
154+
data.Records = FormatDNSResult(result)
155+
}
154156

155157
if len(req.RawAssertions) > 0 {
156158
if j, err := json.Marshal(req.RawAssertions); err == nil {
@@ -330,6 +332,7 @@ func FormatDNSResult(result *checker.DnsResponse) map[string][]string {
330332
mx := make([]string, 0)
331333
ns := make([]string, 0)
332334
txt := make([]string, 0)
335+
333336
for _, v := range result.A {
334337
a = append(a, v)
335338
}

0 commit comments

Comments
 (0)