|
| 1 | +package apiserver_test |
| 2 | + |
| 3 | +import ( |
| 4 | + "crypto/tls" |
| 5 | + "testing" |
| 6 | + |
| 7 | + "github.com/operator-framework/operator-lifecycle-manager/pkg/lib/apiserver" |
| 8 | + "github.com/stretchr/testify/assert" |
| 9 | + "github.com/stretchr/testify/require" |
| 10 | +) |
| 11 | + |
| 12 | +func TestNoopQuerier_QueryTLSConfig(t *testing.T) { |
| 13 | + tests := []struct { |
| 14 | + name string |
| 15 | + config *tls.Config |
| 16 | + expectError bool |
| 17 | + errorMsg string |
| 18 | + }{ |
| 19 | + { |
| 20 | + name: "WithNilConfig", |
| 21 | + config: nil, |
| 22 | + expectError: true, |
| 23 | + errorMsg: "tls.Config cannot be nil", |
| 24 | + }, |
| 25 | + { |
| 26 | + name: "WithEmptyConfig", |
| 27 | + config: &tls.Config{}, |
| 28 | + expectError: false, |
| 29 | + }, |
| 30 | + { |
| 31 | + name: "WithPartialConfig", |
| 32 | + config: &tls.Config{ |
| 33 | + MinVersion: tls.VersionTLS12, |
| 34 | + }, |
| 35 | + expectError: false, |
| 36 | + }, |
| 37 | + } |
| 38 | + |
| 39 | + for _, tt := range tests { |
| 40 | + t.Run(tt.name, func(t *testing.T) { |
| 41 | + querier := apiserver.NoopQuerier() |
| 42 | + err := querier.QueryTLSConfig(tt.config) |
| 43 | + |
| 44 | + if tt.expectError { |
| 45 | + require.Error(t, err) |
| 46 | + assert.Contains(t, err.Error(), tt.errorMsg) |
| 47 | + } else { |
| 48 | + require.NoError(t, err) |
| 49 | + // Verify secure defaults are applied |
| 50 | + assert.NotZero(t, tt.config.MinVersion, "MinVersion should be set to a default") |
| 51 | + assert.NotEmpty(t, tt.config.CipherSuites, "CipherSuites should be set to defaults") |
| 52 | + assert.True(t, tt.config.PreferServerCipherSuites, "PreferServerCipherSuites should be true") |
| 53 | + } |
| 54 | + }) |
| 55 | + } |
| 56 | +} |
| 57 | + |
| 58 | +func TestNoopQuerier_AppliesSecureDefaults(t *testing.T) { |
| 59 | + querier := apiserver.NoopQuerier() |
| 60 | + config := &tls.Config{} |
| 61 | + |
| 62 | + err := querier.QueryTLSConfig(config) |
| 63 | + require.NoError(t, err) |
| 64 | + |
| 65 | + // Verify secure defaults |
| 66 | + assert.GreaterOrEqual(t, config.MinVersion, uint16(tls.VersionTLS12), "Should use at least TLS 1.2") |
| 67 | + assert.NotEmpty(t, config.CipherSuites, "Should have cipher suites configured") |
| 68 | + |
| 69 | + // Verify cipher suites are valid |
| 70 | + for _, cipher := range config.CipherSuites { |
| 71 | + assert.NotZero(t, cipher, "Cipher suite should not be zero") |
| 72 | + } |
| 73 | +} |
| 74 | + |
| 75 | +func TestNoopQuerier_DoesNotOverwriteNonZeroMinVersion(t *testing.T) { |
| 76 | + querier := apiserver.NoopQuerier() |
| 77 | + config := &tls.Config{ |
| 78 | + MinVersion: tls.VersionTLS13, |
| 79 | + } |
| 80 | + |
| 81 | + err := querier.QueryTLSConfig(config) |
| 82 | + require.NoError(t, err) |
| 83 | + |
| 84 | + // MinVersion should be preserved if already set |
| 85 | + assert.Equal(t, uint16(tls.VersionTLS13), config.MinVersion, "Should preserve existing MinVersion") |
| 86 | +} |
0 commit comments