Skip to content

Commit f081e61

Browse files
benh-debianWangYuli
authored andcommitted
debian: firmware_loader: Log direct loading failures as info for d-i
On an installed Debian system, firmware packages will normally be installed automatically based on a mapping of device IDs to firmware. Within the Debian installer this has not yet happened and we need a way to detect missing firmware. Although many/most drivers log firmware loading failures, they do so using many different formats. This adds a single log message to the firmware loader, which the installer's hw-detect package will look for. The log level is set to "info" because some failures are expected and we do not want to confuse users with bogus error messages (like in bug #966218). NOTE: The log message format must not be changed without coordinating this with the check-missing-firmware.sh in hw-detect. Link: https://salsa.debian.org/kernel-team/linux/-/blob/debian/6.11/trixie/debian/patches/debian/firmware_loader-log-direct-loading-failures-as-info-for-d-i.path Signed-off-by: Wentao Guan <guanwentao@uniontech.com>
1 parent 71ac0b7 commit f081e61

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

  • drivers/base/firmware_loader

drivers/base/firmware_loader/main.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -585,6 +585,10 @@ fw_get_filesystem_firmware(struct device *device, struct fw_priv *fw_priv,
585585
}
586586
__putname(path);
587587

588+
if (rc)
589+
dev_info(device, "firmware: failed to load %s (%d)\n",
590+
fw_priv->fw_name, rc);
591+
588592
return rc;
589593
}
590594

0 commit comments

Comments
 (0)