fix: yarn argument value identified as a package#166
Merged
baruchiro merged 4 commits intoFeb 21, 2024
Merged
Conversation
Contributor
Author
|
Sorry |
baruchiro
requested changes
Feb 19, 2024
Collaborator
baruchiro
left a comment
baruchiro
left a comment
There was a problem hiding this comment.
Every time I think something is a simple fix, but nothing in the shared.js file is simple for newcomers (and even for me, after long time). We need to refactor it to be simpler but it is not the scope.
I hope you will find the way to improve your contribution after my comment
Please let me know if you need help to complete this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #156
In case of Number, handle it as Argument and skip this word.
After the fix: