fix(processor): handle self-closing script tags to prevent null reference error (#601)

Author: astrochemx

.changeset/quick-radios-search.md

@@ -0,0 +1,5 @@
+---
+"eslint-plugin-astro": patch
+---
+
+Fix a `TypeError` that occurs during the preprocessing phase when `eslint-plugin-astro` encounters a self-closing `<script />` tag.

src/processor/index.ts

@@ -60,6 +60,7 @@ function preprocess(
           node.openingElement.name.type === "JSXIdentifier" &&
           node.openingElement.name.name === "script" &&
           node.children.length &&
+          !node.openingElement.selfClosing &&
           !node.openingElement.attributes.some(
             (attr) =>
               attr.type === "JSXAttribute" &&

tests/src/integration/client-javascript.ts

@@ -37,4 +37,25 @@ describe("Integration test for client-side script", () => {
       ],
     )
   })
+
+  it("should work with self-closing script", async () => {
+    const eslint = new ESLint({
+      overrideConfigFile: true,
+      overrideConfig: [...astroPlugin.configs.base],
+    })
+
+    const result = await eslint.lintText(
+      `
+      <script src="something.js" />
+      `,
+      { filePath: "path/to/test.astro" },
+    )
+
+    assert.deepStrictEqual(
+      result
+        .flatMap((r) => r.messages)
+        .map((m) => ({ ruleId: m.ruleId, message: m.message })),
+      [],
+    )
+  })
 })

tests/src/integration/client-typescript.ts

@@ -44,4 +44,33 @@ describe("Integration test for client-side ts", () => {
       ],
     )
   })
+
+  it("should work with self-closing script", async () => {
+    const eslint = new ESLint({
+      overrideConfigFile: true,
+      overrideConfig: [
+        ...astroPlugin.configs.base,
+        {
+          files: ["*.ts", "**/*.ts"],
+          languageOptions: {
+            parser: tsESLintParser,
+          },
+        },
+      ],
+    })
+
+    const result = await eslint.lintText(
+      `
+      <script src="something.ts" />
+      `,
+      { filePath: "path/to/test.astro" },
+    )
+
+    assert.deepStrictEqual(
+      result
+        .flatMap((r) => r.messages)
+        .map((m) => ({ ruleId: m.ruleId, message: m.message })),
+      [],
+    )
+  })
 })