Skip to content

Commit f5c3cec

Browse files
authored
feat: deprecate astro/no-omitted-end-tags (#590)
1 parent da3c327 commit f5c3cec

333 files changed

Lines changed: 188 additions & 2400 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
---
2+
"eslint-plugin-astro": major
3+
---
4+
5+
Deprecate `astro/no-omitted-end-tags`, make it a no-op, and remove it from the
6+
recommended configuration. This rule can no longer report omitted end tags once
7+
Astro's Rust compiler rejects them during parsing.

README.md

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -287,7 +287,6 @@ These rules relate to style guidelines, and are therefore quite subjective:
287287

288288
| Rule ID | Description | |
289289
|:--------|:------------|:---|
290-
| [astro/no-omitted-end-tags](https://ota-meshi.github.io/eslint-plugin-astro/rules/no-omitted-end-tags/) | disallow omitted end tags | ⭐🔧 |
291290
| [astro/prefer-class-list-directive](https://ota-meshi.github.io/eslint-plugin-astro/rules/prefer-class-list-directive/) | require `class:list` directives instead of `class` with expressions | 🔧 |
292291
| [astro/prefer-object-class-list](https://ota-meshi.github.io/eslint-plugin-astro/rules/prefer-object-class-list/) | require use object instead of ternary expression in `class:list` | 🔧 |
293292
| [astro/prefer-split-class-list](https://ota-meshi.github.io/eslint-plugin-astro/rules/prefer-split-class-list/) | require use split array elements in `class:list` | 🔧 |
@@ -345,6 +344,15 @@ These rules extend the rules provided by ESLint itself to work well in Astro com
345344
|:--------|:------------|:---|
346345
| [astro/semi](https://ota-meshi.github.io/eslint-plugin-astro/rules/semi/) | Require or disallow semicolons instead of ASI | 🔧 |
347346

347+
## Deprecated
348+
349+
- ⚠️ We're going to remove deprecated rules in the next major release. Please migrate to successor/new rules.
350+
- 😇 We don't fix bugs which are in deprecated rules since we don't have enough resources.
351+
352+
| Rule ID | Description | |
353+
|:--------|:------------|:---|
354+
| [astro/no-omitted-end-tags](https://ota-meshi.github.io/eslint-plugin-astro/rules/no-omitted-end-tags/) | (no replacement) |
355+
348356
<!--RULES_TABLE_END-->
349357
<!--RULES_SECTION_END-->
350358

docs/rules.md

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@ These rules relate to style guidelines, and are therefore quite subjective:
4848

4949
| Rule ID | Description | |
5050
|:--------|:------------|:---|
51-
| [astro/no-omitted-end-tags](./rules/no-omitted-end-tags.md) | disallow omitted end tags | ⭐🔧 |
5251
| [astro/prefer-class-list-directive](./rules/prefer-class-list-directive.md) | require `class:list` directives instead of `class` with expressions | 🔧 |
5352
| [astro/prefer-object-class-list](./rules/prefer-object-class-list.md) | require use object instead of ternary expression in `class:list` | 🔧 |
5453
| [astro/prefer-split-class-list](./rules/prefer-split-class-list.md) | require use split array elements in `class:list` | 🔧 |
@@ -106,4 +105,13 @@ These rules extend the rules provided by ESLint itself to work well in Astro com
106105
|:--------|:------------|:---|
107106
| [astro/semi](./rules/semi.md) | Require or disallow semicolons instead of ASI | 🔧 |
108107

108+
## Deprecated
109+
110+
- ⚠️ We're going to remove deprecated rules in the next major release. Please migrate to successor/new rules.
111+
- 😇 We don't fix bugs which are in deprecated rules since we don't have enough resources.
112+
113+
| Rule ID | Description | |
114+
|:--------|:------------|:---|
115+
| [astro/no-omitted-end-tags](./rules/no-omitted-end-tags.md) | (no replacement) |
116+
109117
[eslint-plugin-jsx-a11y]: https://github.com/jsx-eslint/eslint-plugin-jsx-a11y

docs/rules/jsx-a11y/alt-text.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,5 @@ This rule was introduced in eslint-plugin-astro v0.11.0
3030

3131
- [Rule source](https://github.com/ota-meshi/eslint-plugin-astro/blob/main/src/rules/jsx-a11y/alt-text.ts)
3232
- [Test source](https://github.com/ota-meshi/eslint-plugin-astro/blob/main/tests/src/rules/jsx-a11y/alt-text.ts)
33-
- [Test fixture sources](https://github.com/ota-meshi/eslint-plugin-astro/tree/main/tests/fixtures/rules/jsx-a11y/alt-text)
3433

3534
<sup>Taken with ❤️ [from eslint-plugin-jsx-a11y](https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/tree/HEAD/docs/rules/alt-text.md)</sup>

docs/rules/jsx-a11y/anchor-ambiguous-text.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,5 @@ This rule was introduced in eslint-plugin-astro v0.22.0
3030

3131
- [Rule source](https://github.com/ota-meshi/eslint-plugin-astro/blob/main/src/rules/jsx-a11y/anchor-ambiguous-text.ts)
3232
- [Test source](https://github.com/ota-meshi/eslint-plugin-astro/blob/main/tests/src/rules/jsx-a11y/anchor-ambiguous-text.ts)
33-
- [Test fixture sources](https://github.com/ota-meshi/eslint-plugin-astro/tree/main/tests/fixtures/rules/jsx-a11y/anchor-ambiguous-text)
3433

3534
<sup>Taken with ❤️ [from eslint-plugin-jsx-a11y](https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/tree/HEAD/docs/rules/anchor-ambiguous-text.md)</sup>

docs/rules/jsx-a11y/anchor-has-content.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,5 @@ This rule was introduced in eslint-plugin-astro v0.11.0
3030

3131
- [Rule source](https://github.com/ota-meshi/eslint-plugin-astro/blob/main/src/rules/jsx-a11y/anchor-has-content.ts)
3232
- [Test source](https://github.com/ota-meshi/eslint-plugin-astro/blob/main/tests/src/rules/jsx-a11y/anchor-has-content.ts)
33-
- [Test fixture sources](https://github.com/ota-meshi/eslint-plugin-astro/tree/main/tests/fixtures/rules/jsx-a11y/anchor-has-content)
3433

3534
<sup>Taken with ❤️ [from eslint-plugin-jsx-a11y](https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/tree/HEAD/docs/rules/anchor-has-content.md)</sup>

docs/rules/jsx-a11y/anchor-is-valid.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,5 @@ This rule was introduced in eslint-plugin-astro v0.11.0
3636

3737
- [Rule source](https://github.com/ota-meshi/eslint-plugin-astro/blob/main/src/rules/jsx-a11y/anchor-is-valid.ts)
3838
- [Test source](https://github.com/ota-meshi/eslint-plugin-astro/blob/main/tests/src/rules/jsx-a11y/anchor-is-valid.ts)
39-
- [Test fixture sources](https://github.com/ota-meshi/eslint-plugin-astro/tree/main/tests/fixtures/rules/jsx-a11y/anchor-is-valid)
4039

4140
<sup>Taken with ❤️ [from eslint-plugin-jsx-a11y](https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/tree/HEAD/docs/rules/anchor-is-valid.md)</sup>

docs/rules/jsx-a11y/aria-activedescendant-has-tabindex.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,5 @@ This rule was introduced in eslint-plugin-astro v0.11.0
4242

4343
- [Rule source](https://github.com/ota-meshi/eslint-plugin-astro/blob/main/src/rules/jsx-a11y/aria-activedescendant-has-tabindex.ts)
4444
- [Test source](https://github.com/ota-meshi/eslint-plugin-astro/blob/main/tests/src/rules/jsx-a11y/aria-activedescendant-has-tabindex.ts)
45-
- [Test fixture sources](https://github.com/ota-meshi/eslint-plugin-astro/tree/main/tests/fixtures/rules/jsx-a11y/aria-activedescendant-has-tabindex)
4645

4746
<sup>Taken with ❤️ [from eslint-plugin-jsx-a11y](https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/tree/HEAD/docs/rules/aria-activedescendant-has-tabindex.md)</sup>

docs/rules/jsx-a11y/aria-props.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,5 @@ This rule was introduced in eslint-plugin-astro v0.11.0
3030

3131
- [Rule source](https://github.com/ota-meshi/eslint-plugin-astro/blob/main/src/rules/jsx-a11y/aria-props.ts)
3232
- [Test source](https://github.com/ota-meshi/eslint-plugin-astro/blob/main/tests/src/rules/jsx-a11y/aria-props.ts)
33-
- [Test fixture sources](https://github.com/ota-meshi/eslint-plugin-astro/tree/main/tests/fixtures/rules/jsx-a11y/aria-props)
3433

3534
<sup>Taken with ❤️ [from eslint-plugin-jsx-a11y](https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/tree/HEAD/docs/rules/aria-props.md)</sup>

docs/rules/jsx-a11y/aria-role.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,5 @@ This rule was introduced in eslint-plugin-astro v0.11.0
3030

3131
- [Rule source](https://github.com/ota-meshi/eslint-plugin-astro/blob/main/src/rules/jsx-a11y/aria-role.ts)
3232
- [Test source](https://github.com/ota-meshi/eslint-plugin-astro/blob/main/tests/src/rules/jsx-a11y/aria-role.ts)
33-
- [Test fixture sources](https://github.com/ota-meshi/eslint-plugin-astro/tree/main/tests/fixtures/rules/jsx-a11y/aria-role)
3433

3534
<sup>Taken with ❤️ [from eslint-plugin-jsx-a11y](https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/tree/HEAD/docs/rules/aria-role.md)</sup>

0 commit comments

Comments
 (0)