Fix RingBuffer::push() loading wrong atomic index (#697)

EasonNYC · eason-gif · web-flow · commit 409b4529fcf8 · 2026-02-23T12:12:07.000-08:00
Co-authored-by: Eason Smith &lt;eason@treeswift.com&gt;
diff --git a/ouster_client/include/ouster/impl/ring_buffer.h b/ouster_client/include/ouster/impl/ring_buffer.h
@@ -148,7 +148,7 @@ class RingBuffer {
         if (full()) {
             throw std::overflow_error("pushed a full ring buffer");
         }
-        size_t write_idx = r_idx_.load();
+        size_t write_idx = w_idx_.load();
         // atomic increment modulo
         while (!w_idx_.compare_exchange_strong(write_idx,
                                                (write_idx + 1) % _capacity())) {

Original file line number	Diff line number	Diff line change
`@@ -148,7 +148,7 @@ class RingBuffer {`
`148`	`148`	`if (full()) {`
`149`	`149`	`throw std::overflow_error("pushed a full ring buffer");`
`150`	`150`	`}`
`151`		`- size_t write_idx = r_idx_.load();`
	`151`	`+ size_t write_idx = w_idx_.load();`
`152`	`152`	`// atomic increment modulo`
`153`	`153`	`while (!w_idx_.compare_exchange_strong(write_idx,`
`154`	`154`	`(write_idx + 1) % _capacity())) {`