Remove some substrate dependencies to improve compile time#194
Merged
Remove some substrate dependencies to improve compile time#194
Conversation
ascjones
changed the title
dvdplm
suggested changes
Dec 2, 2020
Contributor
dvdplm
left a comment
dvdplm
left a comment
There was a problem hiding this comment.
LGTM, and the speedup is real! Left a few nitpicks.
dvdplm
approved these changes
Dec 3, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes some big substrate dependencies which were only being used for one or two types. I have just copied these over verbatim, which is acceptable since we are targeting a specific version of substrate at the moment.
This shaves about a minute off the compile time, down from 3:42 to 2:46 on my machine.