feat: Enable retrieval of constants from runtime metadata#207
Merged
feat: Enable retrieval of constants from runtime metadata#207
Conversation
ascjones
reviewed
Dec 17, 2020
| /// Get a constant's metadata by name | ||
| pub fn constant( | ||
| &self, | ||
| key: &'static str, |
Contributor
There was a problem hiding this comment.
Suggested change
| key: &'static str, | |
| key: &str, |
No need to restrict it to 'static
Contributor
There was a problem hiding this comment.
I see now some of the other similar methods are also 'static, but I don't think they need to be if we make the respective Error variants have a String instead.
ascjones
approved these changes
Dec 17, 2020
Contributor
ascjones
left a comment
There was a problem hiding this comment.
LGTM
We can figure out whether to allow non 'static keys in another PR.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #205
Example of new public api usage and outputs