Skip to content

Commit 1e098ce

Browse files
authored
Add missing 'children' prop in several places (#7363)
1 parent 9595ee0 commit 1e098ce

File tree

9 files changed

+9
-2
lines changed

9 files changed

+9
-2
lines changed

packages/react-core/src/components/Select/SelectMenu.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -268,7 +268,7 @@ class SelectMenuWithRef extends React.Component<SelectMenuProps> {
268268
}
269269
}
270270

271-
export const SelectMenu = React.forwardRef((props, ref) => (
271+
export const SelectMenu = React.forwardRef<unknown, React.PropsWithChildren<unknown>>((props, ref) => (
272272
<SelectMenuWithRef innerRef={ref} {...props}>
273273
{props.children}
274274
</SelectMenuWithRef>

packages/react-topology/src/components/ComputeElementDimensions.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import Dimensions from '../geom/Dimensions';
55
import { Node } from '../types';
66

77
interface ComputeElementDimensionsProps {
8+
children?: React.ReactNode;
89
element: Node;
910
}
1011

packages/react-topology/src/components/contextmenu/ContextMenu.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import Popper from '../popper/Popper';
88

99
type ContextMenuProps = Pick<
1010
React.ComponentProps<typeof Popper>,
11-
'container' | 'className' | 'open' | 'reference' | 'onRequestClose'
11+
'children' | 'container' | 'className' | 'open' | 'reference' | 'onRequestClose'
1212
>;
1313

1414
const ContextMenu: React.FunctionComponent<ContextMenuProps> = ({

packages/react-topology/src/components/decorators/Decorator.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import { createSvgIdUrl, useHover } from '../../utils';
66
import { DEFAULT_DECORATOR_PADDING } from '../nodes';
77

88
interface DecoratorTypes {
9+
children?: React.ReactNode;
910
className?: string;
1011
x: number;
1112
y: number;

packages/react-topology/src/components/edges/DefaultEdge.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ import { Point } from '../../geom';
2121
import { getConnectorStartPoint } from './terminals/terminalUtils';
2222

2323
type BaseEdgeProps = {
24+
children?: React.ReactNode;
2425
element: Edge;
2526
dragging?: boolean;
2627
className?: string;

packages/react-topology/src/components/groups/DefaultGroupCollapsed.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ import LabelBadge from '../nodes/labels/LabelBadge';
2121
import { CollapsibleGroupProps } from './types';
2222

2323
type DefaultGroupCollapsedProps = {
24+
children?: React.ReactNode;
2425
className?: string;
2526
element: Node;
2627
droppable?: boolean;

packages/react-topology/src/components/nodes/DefaultNode.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ const getStatusIcon = (status: NodeStatus) => {
3737
};
3838

3939
type DefaultNodeProps = {
40+
children?: React.ReactNode;
4041
className?: string;
4142
element: Node;
4243
droppable?: boolean;

packages/react-topology/src/components/popper/Popper.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ const getReference = (reference: Reference): PopperJSReference =>
5050
'getBoundingClientRect' in reference ? reference : new VirtualReference(reference);
5151

5252
interface PopperProps {
53+
children?: React.ReactNode;
5354
closeOnEsc?: boolean;
5455
closeOnOutsideClick?: boolean;
5556
container?: React.ComponentProps<typeof Portal>['container'];

packages/react-topology/src/components/popper/Portal.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import { useIsomorphicLayoutEffect } from '@patternfly/react-core';
55
type GetContainer = Element | null | undefined | (() => Element);
66

77
interface PortalProps {
8+
children?: React.ReactNode;
89
container?: GetContainer;
910
}
1011

0 commit comments

Comments
 (0)