Skip to content

Commit 62fd6e8

Browse files
tlabajtlabaj
authored
Revert "Fix for no autocomplete for Typeahead Select (#6623)"
This reverts commit ccf6bfe.
1 parent 37fa8d7 commit 62fd6e8

File tree

2 files changed

+27
-27
lines changed

2 files changed

+27
-27
lines changed

‎packages/react-core/src/components/Select/Select.tsx‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -953,7 +953,7 @@ export class Select extends React.Component<SelectProps & OUIAProps, SelectState
953953
}
954954
}}
955955
ref={this.filterRef}
956-
autoComplete="never"
956+
autoComplete="off"
957957
/>
958958
</div>
959959
<Divider key="inline-filter-divider" />
@@ -1147,7 +1147,7 @@ export class Select extends React.Component<SelectProps & OUIAProps, SelectState
11471147
type="text"
11481148
onClick={this.onClick}
11491149
onChange={this.onChange}
1150-
autoComplete="never"
1150+
autoComplete="off"
11511151
disabled={isDisabled}
11521152
ref={this.inputRef}
11531153
/>
@@ -1171,7 +1171,7 @@ export class Select extends React.Component<SelectProps & OUIAProps, SelectState
11711171
type="text"
11721172
onChange={this.onChange}
11731173
onClick={this.onClick}
1174-
autoComplete="never"
1174+
autoComplete="off"
11751175
disabled={isDisabled}
11761176
ref={this.inputRef}
11771177
/>

‎packages/react-core/src/components/Select/__tests__/__snapshots__/Select.test.tsx.snap‎

Lines changed: 24 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -2838,7 +2838,7 @@ exports[`checkbox select renders expanded with filtering successfully 1`] = `
28382838
class="pf-c-select__menu-search"
28392839
>
28402840
<input
2841-
autocomplete="never"
2841+
autocomplete="off"
28422842
class="pf-c-form-control pf-m-search"
28432843
type="search"
28442844
/>
@@ -2963,7 +2963,7 @@ exports[`checkbox select renders expanded with filtering successfully 1`] = `
29632963
class="pf-c-select__menu-search"
29642964
>
29652965
<input
2966-
autocomplete="never"
2966+
autocomplete="off"
29672967
class="pf-c-form-control pf-m-search"
29682968
type="search"
29692969
/>
@@ -3129,7 +3129,7 @@ exports[`checkbox select renders expanded with filtering successfully 1`] = `
31293129
class="pf-c-select__menu-search"
31303130
>
31313131
<input
3132-
autocomplete="never"
3132+
autocomplete="off"
31333133
class="pf-c-form-control pf-m-search"
31343134
type="search"
31353135
/>
@@ -3221,7 +3221,7 @@ exports[`checkbox select renders expanded with filtering successfully 1`] = `
32213221
key="inline-filter"
32223222
>
32233223
<input
3224-
autoComplete="never"
3224+
autoComplete="off"
32253225
className="pf-c-form-control pf-m-search"
32263226
key="inline-filter-input"
32273227
onChange={[Function]}
@@ -3493,7 +3493,7 @@ exports[`checkbox select renders expanded with filtering successfully 2`] = `
34933493
class="pf-c-select__menu-search"
34943494
>
34953495
<input
3496-
autocomplete="never"
3496+
autocomplete="off"
34973497
class="pf-c-form-control pf-m-search"
34983498
type="search"
34993499
/>
@@ -3618,7 +3618,7 @@ exports[`checkbox select renders expanded with filtering successfully 2`] = `
36183618
class="pf-c-select__menu-search"
36193619
>
36203620
<input
3621-
autocomplete="never"
3621+
autocomplete="off"
36223622
class="pf-c-form-control pf-m-search"
36233623
type="search"
36243624
/>
@@ -3784,7 +3784,7 @@ exports[`checkbox select renders expanded with filtering successfully 2`] = `
37843784
class="pf-c-select__menu-search"
37853785
>
37863786
<input
3787-
autocomplete="never"
3787+
autocomplete="off"
37883788
class="pf-c-form-control pf-m-search"
37893789
type="search"
37903790
/>
@@ -3876,7 +3876,7 @@ exports[`checkbox select renders expanded with filtering successfully 2`] = `
38763876
key="inline-filter"
38773877
>
38783878
<input
3879-
autoComplete="never"
3879+
autoComplete="off"
38803880
className="pf-c-form-control pf-m-search"
38813881
key="inline-filter-input"
38823882
onChange={[Function]}
@@ -6012,7 +6012,7 @@ exports[`select custom select filter filters properly 1`] = `
60126012
>
60136013
<input
60146014
aria-label=""
6015-
autocomplete="never"
6015+
autocomplete="off"
60166016
class="pf-c-form-control pf-c-select__toggle-typeahead"
60176017
id="custom-select-filters-select-typeahead"
60186018
placeholder=""
@@ -6108,7 +6108,7 @@ exports[`select custom select filter filters properly 1`] = `
61086108
<input
61096109
aria-activedescendant={null}
61106110
aria-label=""
6111-
autoComplete="never"
6111+
autoComplete="off"
61126112
className="pf-c-form-control pf-c-select__toggle-typeahead"
61136113
disabled={false}
61146114
id="custom-select-filters-select-typeahead"
@@ -9614,7 +9614,7 @@ exports[`typeahead multi select renders closed successfully 1`] = `
96149614
<input
96159615
aria-invalid="false"
96169616
aria-label=""
9617-
autocomplete="never"
9617+
autocomplete="off"
96189618
class="pf-c-form-control pf-c-select__toggle-typeahead"
96199619
id="typeahead-multi-select-closed-select-multi-typeahead-typeahead"
96209620
placeholder=""
@@ -9666,7 +9666,7 @@ exports[`typeahead multi select renders closed successfully 1`] = `
96669666
aria-activedescendant={null}
96679667
aria-invalid={false}
96689668
aria-label=""
9669-
autoComplete="never"
9669+
autoComplete="off"
96709670
className="pf-c-form-control pf-c-select__toggle-typeahead"
96719671
disabled={false}
96729672
id="typeahead-multi-select-closed-select-multi-typeahead-typeahead"
@@ -9876,7 +9876,7 @@ exports[`typeahead multi select renders expanded successfully 1`] = `
98769876
<input
98779877
aria-invalid="false"
98789878
aria-label=""
9879-
autocomplete="never"
9879+
autocomplete="off"
98809880
class="pf-c-form-control pf-c-select__toggle-typeahead"
98819881
id="pf-select-toggle-id-13-select-multi-typeahead-typeahead"
98829882
placeholder=""
@@ -9986,7 +9986,7 @@ exports[`typeahead multi select renders expanded successfully 1`] = `
99869986
aria-activedescendant={null}
99879987
aria-invalid={false}
99889988
aria-label=""
9989-
autoComplete="never"
9989+
autoComplete="off"
99909990
className="pf-c-form-control pf-c-select__toggle-typeahead"
99919991
disabled={false}
99929992
id="pf-select-toggle-id-13-select-multi-typeahead-typeahead"
@@ -10606,7 +10606,7 @@ exports[`typeahead multi select renders selected successfully 1`] = `
1060610606
<input
1060710607
aria-invalid="false"
1060810608
aria-label=""
10609-
autocomplete="never"
10609+
autocomplete="off"
1061010610
class="pf-c-form-control pf-c-select__toggle-typeahead"
1061110611
id="typeahead-multi-select-selected-select-multi-typeahead-typeahead"
1061210612
placeholder=""
@@ -10970,7 +10970,7 @@ exports[`typeahead multi select renders selected successfully 1`] = `
1097010970
aria-activedescendant={null}
1097110971
aria-invalid={false}
1097210972
aria-label=""
10973-
autoComplete="never"
10973+
autoComplete="off"
1097410974
className="pf-c-form-control pf-c-select__toggle-typeahead"
1097510975
disabled={false}
1097610976
id="typeahead-multi-select-selected-select-multi-typeahead-typeahead"
@@ -11494,7 +11494,7 @@ exports[`typeahead select renders closed successfully 1`] = `
1149411494
>
1149511495
<input
1149611496
aria-label=""
11497-
autocomplete="never"
11497+
autocomplete="off"
1149811498
class="pf-c-form-control pf-c-select__toggle-typeahead"
1149911499
id="typeahead-select-closed-select-typeahead"
1150011500
placeholder=""
@@ -11545,7 +11545,7 @@ exports[`typeahead select renders closed successfully 1`] = `
1154511545
<input
1154611546
aria-activedescendant={null}
1154711547
aria-label=""
11548-
autoComplete="never"
11548+
autoComplete="off"
1154911549
className="pf-c-form-control pf-c-select__toggle-typeahead"
1155011550
disabled={false}
1155111551
id="typeahead-select-closed-select-typeahead"
@@ -11754,7 +11754,7 @@ exports[`typeahead select renders expanded successfully 1`] = `
1175411754
>
1175511755
<input
1175611756
aria-label=""
11757-
autocomplete="never"
11757+
autocomplete="off"
1175811758
class="pf-c-form-control pf-c-select__toggle-typeahead"
1175911759
id="pf-select-toggle-id-8-select-typeahead"
1176011760
placeholder=""
@@ -11863,7 +11863,7 @@ exports[`typeahead select renders expanded successfully 1`] = `
1186311863
<input
1186411864
aria-activedescendant={null}
1186511865
aria-label=""
11866-
autoComplete="never"
11866+
autoComplete="off"
1186711867
className="pf-c-form-control pf-c-select__toggle-typeahead"
1186811868
disabled={false}
1186911869
id="pf-select-toggle-id-8-select-typeahead"
@@ -12357,7 +12357,7 @@ exports[`typeahead select renders selected successfully 1`] = `
1235712357
>
1235812358
<input
1235912359
aria-label=""
12360-
autocomplete="never"
12360+
autocomplete="off"
1236112361
class="pf-c-form-control pf-c-select__toggle-typeahead"
1236212362
id="pf-select-toggle-id-9-select-typeahead"
1236312363
placeholder=""
@@ -12484,7 +12484,7 @@ exports[`typeahead select renders selected successfully 1`] = `
1248412484
<input
1248512485
aria-activedescendant={null}
1248612486
aria-label=""
12487-
autoComplete="never"
12487+
autoComplete="off"
1248812488
className="pf-c-form-control pf-c-select__toggle-typeahead"
1248912489
disabled={false}
1249012490
id="pf-select-toggle-id-9-select-typeahead"
@@ -12968,7 +12968,7 @@ exports[`typeahead select test select existing option on a non-creatable select
1296812968
>
1296912969
<input
1297012970
aria-label=""
12971-
autocomplete="never"
12971+
autocomplete="off"
1297212972
class="pf-c-form-control pf-c-select__toggle-typeahead"
1297312973
id="pf-select-toggle-id-12-select-typeahead"
1297412974
placeholder=""
@@ -13038,7 +13038,7 @@ exports[`typeahead select test select existing option on a non-creatable select
1303813038
<input
1303913039
aria-activedescendant={null}
1304013040
aria-label=""
13041-
autoComplete="never"
13041+
autoComplete="off"
1304213042
className="pf-c-form-control pf-c-select__toggle-typeahead"
1304313043
disabled={false}
1304413044
id="pf-select-toggle-id-12-select-typeahead"

0 commit comments

Comments
 (0)