Skip to content

Commit e287bfc

Browse files
author
Jeff Puzzo
committed
allow for SVG imports in react-core for TSX examples
1 parent d796863 commit e287bfc

File tree

5 files changed

+15
-12
lines changed

5 files changed

+15
-12
lines changed

packages/react-core/index.d.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
declare module '*.svg' {
2+
const content: string;
3+
export default content;
4+
}
Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,12 @@
11
import React from 'react';
2-
import { Banner } from '@patternfly/react-core';
2+
import { Banner, Flex } from '@patternfly/react-core';
33

44
export const BannerBasic: React.FunctionComponent = () => (
5-
<React.Fragment>
5+
<Flex direction={{ default: 'column' }}>
66
<Banner>Default banner</Banner>
7-
<br />
87
<Banner variant="info">Info banner</Banner>
9-
<br />
108
<Banner variant="danger">Danger banner</Banner>
11-
<br />
129
<Banner variant="success">Success banner</Banner>
13-
<br />
1410
<Banner variant="warning">Warning banner</Banner>
15-
</React.Fragment>
11+
</Flex>
1612
);

packages/react-core/src/components/Brand/examples/Brand.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ cssPrefix: null
55
propComponents: ['Brand']
66
---
77

8+
import pfLogo from './pfLogo.svg';
9+
810
## Examples
911

1012
### Basic
Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import React from 'react';
22
import { Brand } from '@patternfly/react-core';
3+
import pfLogo from './pfLogo.svg';
34

4-
export const BrandBasic: React.FunctionComponent = () => <Brand src="./pfLogo.svg" alt="Patternfly Logo" />;
5+
export const BrandBasic: React.FunctionComponent = () => <Brand src={pfLogo} alt="Patternfly Logo" />;

packages/react-core/src/components/Breadcrumb/examples/BreadcrumbDropdown.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import {
99
} from '@patternfly/react-core';
1010
import AngleLeftIcon from '@patternfly/react-icons/dist/esm/icons/angle-left-icon';
1111

12-
const dropdownItems = [
12+
const dropdownItems: JSX.Element[] = [
1313
<DropdownItem key="edit" component="button" icon={<AngleLeftIcon />}>
1414
Edit
1515
</DropdownItem>,
@@ -22,13 +22,13 @@ const dropdownItems = [
2222
];
2323

2424
export const BreadcrumbDropdown: React.FunctionComponent = () => {
25-
const [isOpen, setIsOpen] = React.useState(false);
25+
const [isOpen, setIsOpen] = React.useState<boolean>(false);
2626
const badgeToggleRef = React.useRef<HTMLButtonElement>();
2727

28-
const onToggle = React.useCallback(isOpen => setIsOpen(isOpen), []);
28+
const onToggle = React.useCallback((isOpen: boolean) => setIsOpen(isOpen), []);
2929

3030
const onSelect = React.useCallback(() => {
31-
setIsOpen(prevIsOpen => !prevIsOpen);
31+
setIsOpen((prevIsOpen: boolean) => !prevIsOpen);
3232
badgeToggleRef.current.focus();
3333
}, []);
3434

0 commit comments

Comments
 (0)