allow no onSelect, update integration and snap

kmcfaul · kmcfaul · commit e4ed53e70309 · 2023-02-09T10:19:40.000-05:00
diff --git a/packages/react-core/src/next/components/Dropdown/Dropdown.tsx b/packages/react-core/src/next/components/Dropdown/Dropdown.tsx
@@ -103,7 +103,7 @@ const DropdownBase: React.FunctionComponent<DropdownProps> = ({
     <Menu
       className={css(className)}
       ref={menuRef}
-      onSelect={(event, itemId) => onSelect(event, itemId)}
+      onSelect={(event, itemId) => onSelect && onSelect(event, itemId)}
       isPlain={isPlain}
       isScrollable={isScrollable}
       {...(minWidth && {
diff --git a/packages/react-core/src/next/components/Select/Select.tsx b/packages/react-core/src/next/components/Select/Select.tsx
@@ -97,7 +97,7 @@ const SelectBase: React.FunctionComponent<SelectProps & OUIAProps> = ({
       role={role}
       className={css(className)}
       ref={menuRef}
-      onSelect={(event, itemId) => onSelect(event, itemId)}
+      onSelect={(event, itemId) => onSelect && onSelect(event, itemId)}
       isPlain={isPlain}
       selected={selected}
       {...(minWidth && {
diff --git a/packages/react-integration/cypress/integration/tablesimpleactions.spec.ts b/packages/react-integration/cypress/integration/tablesimpleactions.spec.ts
@@ -20,14 +20,14 @@ describe('Table Simple Actions Test', () => {
   });
 
   it('Verify dropdown toggle', () => {
-    cy.get('td .pf-c-dropdown__toggle')
+    cy.get('td .pf-c-menu-toggle')
       .first()
       .should('exist');
-    cy.get('td .pf-c-dropdown__toggle')
+    cy.get('td .pf-c-menu-toggle')
       .first()
       .click();
-    cy.get('.pf-c-dropdown__menu').should('exist');
-    cy.get('.pf-c-dropdown__menu-item')
+    cy.get('.pf-c-menu').should('exist');
+    cy.get('.pf-c-menu__item')
       .first()
       .click();
   });
diff --git a/packages/react-table/src/components/Table/__tests__/__snapshots__/Table.test.tsx.snap b/packages/react-table/src/components/Table/__tests__/__snapshots__/Table.test.tsx.snap
@@ -157,6 +157,7 @@ exports[`Table Actions table 1`] = `
             >
               <button
                 aria-expanded="false"
+                aria-label="Kebab toggle"
                 class="pf-c-menu-toggle pf-m-plain"
                 type="button"
               >
@@ -234,6 +235,7 @@ exports[`Table Actions table 1`] = `
             >
               <button
                 aria-expanded="false"
+                aria-label="Kebab toggle"
                 class="pf-c-menu-toggle pf-m-plain"
                 type="button"
               >
@@ -311,6 +313,7 @@ exports[`Table Actions table 1`] = `
             >
               <button
                 aria-expanded="false"
+                aria-label="Kebab toggle"
                 class="pf-c-menu-toggle pf-m-plain"
                 type="button"
               >
@@ -388,6 +391,7 @@ exports[`Table Actions table 1`] = `
             >
               <button
                 aria-expanded="false"
+                aria-label="Kebab toggle"
                 class="pf-c-menu-toggle pf-m-plain"
                 type="button"
               >
@@ -465,6 +469,7 @@ exports[`Table Actions table 1`] = `
             >
               <button
                 aria-expanded="false"
+                aria-label="Kebab toggle"
                 class="pf-c-menu-toggle pf-m-plain"
                 type="button"
               >
@@ -542,6 +547,7 @@ exports[`Table Actions table 1`] = `
             >
               <button
                 aria-expanded="false"
+                aria-label="Kebab toggle"
                 class="pf-c-menu-toggle pf-m-plain"
                 type="button"
               >
@@ -619,6 +625,7 @@ exports[`Table Actions table 1`] = `
             >
               <button
                 aria-expanded="false"
+                aria-label="Kebab toggle"
                 class="pf-c-menu-toggle pf-m-plain"
                 type="button"
               >
@@ -696,6 +703,7 @@ exports[`Table Actions table 1`] = `
             >
               <button
                 aria-expanded="false"
+                aria-label="Kebab toggle"
                 class="pf-c-menu-toggle pf-m-plain"
                 type="button"
               >
@@ -773,6 +781,7 @@ exports[`Table Actions table 1`] = `
             >
               <button
                 aria-expanded="false"
+                aria-label="Kebab toggle"
                 class="pf-c-menu-toggle pf-m-plain"
                 type="button"
               >
@@ -5383,6 +5392,7 @@ exports[`Table Simple Actions table 1`] = `
             >
               <button
                 aria-expanded="false"
+                aria-label="Kebab toggle"
                 class="pf-c-menu-toggle pf-m-plain"
                 type="button"
               >
@@ -5460,6 +5470,7 @@ exports[`Table Simple Actions table 1`] = `
             >
               <button
                 aria-expanded="false"
+                aria-label="Kebab toggle"
                 class="pf-c-menu-toggle pf-m-plain"
                 type="button"
               >
@@ -5537,6 +5548,7 @@ exports[`Table Simple Actions table 1`] = `
             >
               <button
                 aria-expanded="false"
+                aria-label="Kebab toggle"
                 class="pf-c-menu-toggle pf-m-plain"
                 type="button"
               >
@@ -5614,6 +5626,7 @@ exports[`Table Simple Actions table 1`] = `
             >
               <button
                 aria-expanded="false"
+                aria-label="Kebab toggle"
                 class="pf-c-menu-toggle pf-m-plain"
                 type="button"
               >
@@ -5691,6 +5704,7 @@ exports[`Table Simple Actions table 1`] = `
             >
               <button
                 aria-expanded="false"
+                aria-label="Kebab toggle"
                 class="pf-c-menu-toggle pf-m-plain"
                 type="button"
               >
@@ -5768,6 +5782,7 @@ exports[`Table Simple Actions table 1`] = `
             >
               <button
                 aria-expanded="false"
+                aria-label="Kebab toggle"
                 class="pf-c-menu-toggle pf-m-plain"
                 type="button"
               >
@@ -5845,6 +5860,7 @@ exports[`Table Simple Actions table 1`] = `
             >
               <button
                 aria-expanded="false"
+                aria-label="Kebab toggle"
                 class="pf-c-menu-toggle pf-m-plain"
                 type="button"
               >
@@ -5922,6 +5938,7 @@ exports[`Table Simple Actions table 1`] = `
             >
               <button
                 aria-expanded="false"
+                aria-label="Kebab toggle"
                 class="pf-c-menu-toggle pf-m-plain"
                 type="button"
               >
@@ -5999,6 +6016,7 @@ exports[`Table Simple Actions table 1`] = `
             >
               <button
                 aria-expanded="false"
+                aria-label="Kebab toggle"
                 class="pf-c-menu-toggle pf-m-plain"
                 type="button"
               >
@@ -6076,6 +6094,7 @@ exports[`Table Simple Actions table 1`] = `
             >
               <button
                 aria-expanded="false"
+                aria-label="Kebab toggle"
                 class="pf-c-menu-toggle pf-m-plain pf-m-disabled"
                 disabled=""
                 type="button"

Original file line number	Diff line number	Diff line change
@@ -157,6 +157,7 @@ exports[`Table Actions table 1`] = `
`157`	`157`	`>`
`158`	`158`	`<button`
`159`	`159`	`aria-expanded="false"`
	`160`	`+ aria-label="Kebab toggle"`
`160`	`161`	`class="pf-c-menu-toggle pf-m-plain"`
`161`	`162`	`type="button"`
`162`	`163`	`>`
@@ -234,6 +235,7 @@ exports[`Table Actions table 1`] = `
`234`	`235`	`>`
`235`	`236`	`<button`
`236`	`237`	`aria-expanded="false"`
	`238`	`+ aria-label="Kebab toggle"`
`237`	`239`	`class="pf-c-menu-toggle pf-m-plain"`
`238`	`240`	`type="button"`
`239`	`241`	`>`
@@ -311,6 +313,7 @@ exports[`Table Actions table 1`] = `
`311`	`313`	`>`
`312`	`314`	`<button`
`313`	`315`	`aria-expanded="false"`
	`316`	`+ aria-label="Kebab toggle"`
`314`	`317`	`class="pf-c-menu-toggle pf-m-plain"`
`315`	`318`	`type="button"`
`316`	`319`	`>`
@@ -388,6 +391,7 @@ exports[`Table Actions table 1`] = `
`388`	`391`	`>`
`389`	`392`	`<button`
`390`	`393`	`aria-expanded="false"`
	`394`	`+ aria-label="Kebab toggle"`
`391`	`395`	`class="pf-c-menu-toggle pf-m-plain"`
`392`	`396`	`type="button"`
`393`	`397`	`>`
@@ -465,6 +469,7 @@ exports[`Table Actions table 1`] = `
`465`	`469`	`>`
`466`	`470`	`<button`
`467`	`471`	`aria-expanded="false"`
	`472`	`+ aria-label="Kebab toggle"`
`468`	`473`	`class="pf-c-menu-toggle pf-m-plain"`
`469`	`474`	`type="button"`
`470`	`475`	`>`
@@ -542,6 +547,7 @@ exports[`Table Actions table 1`] = `
`542`	`547`	`>`
`543`	`548`	`<button`
`544`	`549`	`aria-expanded="false"`
	`550`	`+ aria-label="Kebab toggle"`
`545`	`551`	`class="pf-c-menu-toggle pf-m-plain"`
`546`	`552`	`type="button"`
`547`	`553`	`>`
@@ -619,6 +625,7 @@ exports[`Table Actions table 1`] = `
`619`	`625`	`>`
`620`	`626`	`<button`
`621`	`627`	`aria-expanded="false"`
	`628`	`+ aria-label="Kebab toggle"`
`622`	`629`	`class="pf-c-menu-toggle pf-m-plain"`
`623`	`630`	`type="button"`
`624`	`631`	`>`
@@ -696,6 +703,7 @@ exports[`Table Actions table 1`] = `
`696`	`703`	`>`
`697`	`704`	`<button`
`698`	`705`	`aria-expanded="false"`
	`706`	`+ aria-label="Kebab toggle"`
`699`	`707`	`class="pf-c-menu-toggle pf-m-plain"`
`700`	`708`	`type="button"`
`701`	`709`	`>`
@@ -773,6 +781,7 @@ exports[`Table Actions table 1`] = `
`773`	`781`	`>`
`774`	`782`	`<button`
`775`	`783`	`aria-expanded="false"`
	`784`	`+ aria-label="Kebab toggle"`
`776`	`785`	`class="pf-c-menu-toggle pf-m-plain"`
`777`	`786`	`type="button"`
`778`	`787`	`>`
@@ -5383,6 +5392,7 @@ exports[`Table Simple Actions table 1`] = `
`5383`	`5392`	`>`
`5384`	`5393`	`<button`
`5385`	`5394`	`aria-expanded="false"`
	`5395`	`+ aria-label="Kebab toggle"`
`5386`	`5396`	`class="pf-c-menu-toggle pf-m-plain"`
`5387`	`5397`	`type="button"`
`5388`	`5398`	`>`
@@ -5460,6 +5470,7 @@ exports[`Table Simple Actions table 1`] = `
`5460`	`5470`	`>`
`5461`	`5471`	`<button`
`5462`	`5472`	`aria-expanded="false"`
	`5473`	`+ aria-label="Kebab toggle"`
`5463`	`5474`	`class="pf-c-menu-toggle pf-m-plain"`
`5464`	`5475`	`type="button"`
`5465`	`5476`	`>`
@@ -5537,6 +5548,7 @@ exports[`Table Simple Actions table 1`] = `
`5537`	`5548`	`>`
`5538`	`5549`	`<button`
`5539`	`5550`	`aria-expanded="false"`
	`5551`	`+ aria-label="Kebab toggle"`
`5540`	`5552`	`class="pf-c-menu-toggle pf-m-plain"`
`5541`	`5553`	`type="button"`
`5542`	`5554`	`>`
@@ -5614,6 +5626,7 @@ exports[`Table Simple Actions table 1`] = `
`5614`	`5626`	`>`
`5615`	`5627`	`<button`
`5616`	`5628`	`aria-expanded="false"`
	`5629`	`+ aria-label="Kebab toggle"`
`5617`	`5630`	`class="pf-c-menu-toggle pf-m-plain"`
`5618`	`5631`	`type="button"`
`5619`	`5632`	`>`
@@ -5691,6 +5704,7 @@ exports[`Table Simple Actions table 1`] = `
`5691`	`5704`	`>`
`5692`	`5705`	`<button`
`5693`	`5706`	`aria-expanded="false"`
	`5707`	`+ aria-label="Kebab toggle"`
`5694`	`5708`	`class="pf-c-menu-toggle pf-m-plain"`
`5695`	`5709`	`type="button"`
`5696`	`5710`	`>`
@@ -5768,6 +5782,7 @@ exports[`Table Simple Actions table 1`] = `
`5768`	`5782`	`>`
`5769`	`5783`	`<button`
`5770`	`5784`	`aria-expanded="false"`
	`5785`	`+ aria-label="Kebab toggle"`
`5771`	`5786`	`class="pf-c-menu-toggle pf-m-plain"`
`5772`	`5787`	`type="button"`
`5773`	`5788`	`>`
@@ -5845,6 +5860,7 @@ exports[`Table Simple Actions table 1`] = `
`5845`	`5860`	`>`
`5846`	`5861`	`<button`
`5847`	`5862`	`aria-expanded="false"`
	`5863`	`+ aria-label="Kebab toggle"`
`5848`	`5864`	`class="pf-c-menu-toggle pf-m-plain"`
`5849`	`5865`	`type="button"`
`5850`	`5866`	`>`
@@ -5922,6 +5938,7 @@ exports[`Table Simple Actions table 1`] = `
`5922`	`5938`	`>`
`5923`	`5939`	`<button`
`5924`	`5940`	`aria-expanded="false"`
	`5941`	`+ aria-label="Kebab toggle"`
`5925`	`5942`	`class="pf-c-menu-toggle pf-m-plain"`
`5926`	`5943`	`type="button"`
`5927`	`5944`	`>`
@@ -5999,6 +6016,7 @@ exports[`Table Simple Actions table 1`] = `
`5999`	`6016`	`>`
`6000`	`6017`	`<button`
`6001`	`6018`	`aria-expanded="false"`
	`6019`	`+ aria-label="Kebab toggle"`
`6002`	`6020`	`class="pf-c-menu-toggle pf-m-plain"`
`6003`	`6021`	`type="button"`
`6004`	`6022`	`>`
@@ -6076,6 +6094,7 @@ exports[`Table Simple Actions table 1`] = `
`6076`	`6094`	`>`
`6077`	`6095`	`<button`
`6078`	`6096`	`aria-expanded="false"`
	`6097`	`+ aria-label="Kebab toggle"`
`6079`	`6098`	`class="pf-c-menu-toggle pf-m-plain pf-m-disabled"`
`6080`	`6099`	`disabled=""`
`6081`	`6100`	`type="button"`