Skip to content

Commit f4e415e

Browse files
author
Eric Olkowski
committed
Updated per comments
1 parent d9f6ba2 commit f4e415e

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

packages/react-core/src/components/ContextSelector/ContextSelector.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -141,6 +141,7 @@ export class ContextSelector extends React.Component<ContextSelectorProps, { oui
141141
>
142142
<div className={css(styles.contextSelectorMenuSearch)}>
143143
<SearchInput
144+
type="search"
144145
submitSearchButtonLabel={searchButtonAriaLabel}
145146
placeholder={searchInputPlaceholder}
146147
onChange={onSearchInputChange}

packages/react-core/src/components/ContextSelector/__tests__/__snapshots__/ContextSelector.test.tsx.snap

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ exports[`ContextSelector Renders ContextSelector open 1`] = `
114114
</svg>
115115
</span>
116116
<input
117-
aria-label="Search menu items"
117+
aria-label="Search input"
118118
class="pf-c-text-input-group__text-input"
119119
placeholder="Search"
120120
type="text"
@@ -125,7 +125,7 @@ exports[`ContextSelector Renders ContextSelector open 1`] = `
125125
</div>
126126
<button
127127
aria-disabled="true"
128-
aria-label="Search"
128+
aria-label="Search menu items"
129129
class="pf-c-button pf-m-control pf-m-disabled"
130130
data-ouia-component-id="OUIA-Generated-Button-control-1"
131131
data-ouia-component-type="PF4/Button"
@@ -284,7 +284,7 @@ exports[`ContextSelector Renders in strict mode 1`] = `
284284
</svg>
285285
</span>
286286
<input
287-
aria-label="Search menu items"
287+
aria-label="Search input"
288288
class="pf-c-text-input-group__text-input"
289289
placeholder="Search"
290290
type="text"
@@ -295,7 +295,7 @@ exports[`ContextSelector Renders in strict mode 1`] = `
295295
</div>
296296
<button
297297
aria-disabled="true"
298-
aria-label="Search"
298+
aria-label="Search menu items"
299299
class="pf-c-button pf-m-control pf-m-disabled"
300300
data-ouia-component-id="OUIA-Generated-Button-control-3"
301301
data-ouia-component-type="PF4/Button"

packages/react-core/src/components/SearchInput/SearchInput.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -361,7 +361,7 @@ const SearchInputBase: React.FunctionComponent<SearchInputProps> = ({
361361
variant={ButtonVariant.control}
362362
aria-label={submitSearchButtonLabel}
363363
onClick={onSearchHandler}
364-
isDisabled={isDisabled || !searchValue}
364+
isDisabled={isDisabled}
365365
>
366366
<ArrowRightIcon />
367367
</Button>

0 commit comments

Comments
 (0)