fix(DefaultNode): Fix label flicker on hover#295
Merged
jenny-s51 merged 1 commit intopatternfly:mainfrom Sep 25, 2025
Merged
Conversation
jenny-s51
approved these changes
Sep 25, 2025
Collaborator
jenny-s51
left a comment
jenny-s51
left a comment
There was a problem hiding this comment.
LGTM @jeff-phillips-18 , tested locally and flicker issue can no longer be reproduced.
Opened #296 as a follow up since it's out of scope here.
|
🎉 This PR is included in version 6.3.0-prerelease.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Closes #292
Description
Fixes an issue where the node label flickers on hover and leaving the label after hovering does not remove the hover treatment.
Added a hover check for the label on DefaultNode to specifically watch the hover state on the label.
Type of change
Screen shots / Gifs for design review