#3357 deck: fix url handling

Signed-off-by: Patrizio Bekerle <patrizio@bekerle.com>

Author: pbek

CHANGELOG.md

@@ -2,6 +2,13 @@
 
 ## 26.2.13
 
+- Fixed clicking a Nextcloud Deck link not opening the Nextcloud Deck dialog anymore
+  (for [#3357](https://github.com/pbek/QOwnNotes/issues/3357))
+  - The note editor's `openUrl` method now routes Nextcloud Deck card URLs (`https://…/apps/deck/#/board/…/card/…`) through `UrlHandler` instead of handing them off to `QDesktopServices`
+  - The note preview's anchor-click handler (`onNotePreviewAnchorClicked`) now also recognises Deck card URLs and routes them through `UrlHandler` so the dialog opens correctly from the preview pane as well
+  - The card ID is now parsed directly from the URL path instead of requiring a pre-configured board ID that exactly matches the clicked link, so the dialog opens regardless of which board the card belongs to
+  - Removed the `isEnabled()` gate from the link-click handler so the Nextcloud Deck dialog opens even when the Deck integration is not fully configured for card creation
+
 - Improved multi-note selection preview styling in the QLiteHtml preview widget for dark mode
   (for [#3466](https://github.com/pbek/QOwnNotes/issues/3466))
   - Colors are now derived from the active editor schema instead of hardcoded light/dark fallback

src/mainwindow.cpp

@@ -6484,7 +6484,10 @@ void MainWindow::onNotePreviewAnchorClicked(const QUrl &url) {
     // Check if Ctrl key is pressed to open in new tab
     bool openInNewTab = QGuiApplication::keyboardModifiers().testFlag(Qt::ControlModifier);
 
-    if (UrlHandler::isUrlSchemeLocal(url)) {
+    const bool isLocalScheme = UrlHandler::isUrlSchemeLocal(url);
+    const bool isDeckCardUrl = NextcloudDeckService::isCardUrl(url.toString());
+
+    if (isLocalScheme || isDeckCardUrl) {
         // Update _lastNoteId when opening in a new tab to ensure the current note
         // is correctly placed in the old tab, not some previous note
         if (openInNewTab && currentNote.exists()) {

src/services/nextclouddeckservice.cpp

@@ -241,6 +241,17 @@ QString NextcloudDeckService::getCardUrlPattern() const {
            QStringLiteral("/card/");
 }
 
+int NextcloudDeckService::parseCardIdFromUrlDirectly(const QString& url) {
+    static const QRegularExpression re(QStringLiteral(R"(\/card\/(\d+))"));
+    QRegularExpressionMatch match = re.match(url);
+
+    if (match.hasMatch()) {
+        return match.captured(1).toInt();
+    }
+
+    return -1;
+}
+
 int NextcloudDeckService::parseCardIdFromUrl(const QString& url) const {
     qDebug() << __func__ << "getCardUrlPattern(): " << getCardUrlPattern();
     if (!url.startsWith(getCardUrlPattern())) {

src/services/nextclouddeckservice.h

@@ -61,6 +61,7 @@ class NextcloudDeckService : public QObject {
     bool deleteCard(int cardId);
     int parseCardIdFromUrl(const QString& url) const;
     static bool isCardUrl(const QString& url);
+    static int parseCardIdFromUrlDirectly(const QString& url);
     QString getCardUrlPattern() const;
 
    private:

src/utils/urlhandler.cpp

@@ -81,16 +81,17 @@ void UrlHandler::openUrl(QString urlString, const bool openInNewTab) {
 }
 
 void UrlHandler::handleNextcloudDeckUrl(const QString &urlString) {
-    NextcloudDeckService nextcloudDeckService(MainWindow::instance());
-
-    if (nextcloudDeckService.isEnabled()) {
-        auto cardId = nextcloudDeckService.parseCardIdFromUrl(urlString);
-        qDebug() << __func__ << "cardId: " << cardId;
-
-        if (cardId > 0) {
-            // Open the Nextcloud Deck dialog with the cardId
-            MainWindow::instance()->openNextcloudDeckDialog(cardId);
-        }
+    // Parse the card ID directly from the URL path to avoid requiring
+    // a pre-configured board ID that exactly matches the URL
+    auto cardId = NextcloudDeckService::parseCardIdFromUrlDirectly(urlString);
+    qDebug() << __func__ << "cardId: " << cardId;
+
+    if (cardId > 0) {
+        // Open the Nextcloud Deck dialog with the cardId.
+        // We do not require isEnabled() here because the user explicitly clicked
+        // a Deck link and we should honour that regardless of whether the Deck
+        // integration is fully configured for card creation.
+        MainWindow::instance()->openNextcloudDeckDialog(cardId);
     }
 }
 

src/widgets/qownnotesmarkdowntextedit.cpp

@@ -440,12 +440,12 @@ void QOwnNotesMarkdownTextEdit::openUrl(const QString &urlString, bool openInNew
     QUrl url(urlCopy);
     const QString scheme = url.scheme();
 
-    // If it's a note URL, noteid URL, file URL in note folder, or has no scheme (relative link),
-    // use UrlHandler which knows how to handle notes properly
+    // If it's a note URL, noteid URL, file URL in note folder, has no scheme (relative link),
+    // or is a Nextcloud Deck card URL, use UrlHandler which knows how to handle these properly
     if (scheme == QStringLiteral("note") || scheme == QStringLiteral("noteid") ||
         scheme == QStringLiteral("file") || scheme.isEmpty() ||
-        Note::fileUrlIsNoteInCurrentNoteFolder(url)) {
-        // Use UrlHandler for note URLs with the openInNewTab flag
+        Note::fileUrlIsNoteInCurrentNoteFolder(url) || NextcloudDeckService::isCardUrl(urlCopy)) {
+        // Use UrlHandler for note and Deck URLs with the openInNewTab flag
         UrlHandler().openUrl(urlCopy, openInNewTab);
     } else {
         // For other URLs (http, https, etc.), use the base class implementation