Ensure packaging dependency is self-contained.#355
Merged
Conversation
This dependency was not included in the pex `.bootstrap/` previously leading to issues with use of pex as a library. We use the vendored version from setuptools for now - which it leaks through its API. Notes are added in the right spots to deal with setuptools de-vendoring of `packaging` in its newest releases when we upgrade setuptools next.
Member
Author
|
Now: I also verified setuptools 20.0.0 - our lower bound - has a vendored |
kwlzn
pushed a commit
that referenced
this pull request
May 26, 2017
…r attribute required by PR 355 (#391) In #355 package.py was updated to assume that the Requirement class has the specifier attribute. The specifier attribute wasn't added to the Requirement class until setuptools 20.3 pypa/setuptools@de4bdcf The error when there is an older setuptools is Exception message: Requirement instance has no attribute 'specifier'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This dependency was not included in the pex
.bootstrap/previouslyleading to issues with use of pex as a library. We use the vendored
version from setuptools for now - which it leaks through its API. Notes
are added in the right spots to deal with setuptools de-vendoring of
packagingin its newest releases when we upgrade setuptools next.Closes #354