simplify MixedType::isError

canvural · canvural · commit 08307bdeb3e2 · 2025-12-06T15:04:29.000+01:00
diff --git a/src/Type/MixedType.php b/src/Type/MixedType.php
@@ -1067,13 +1067,7 @@ public function isScalar(): TrinaryLogic
 
 	public function isError(): TrinaryLogic
 	{
-		if ($this->subtractedType !== null) {
-			if ($this->subtractedType->isSuperTypeOf(new ErrorType())->yes()) {
-				return TrinaryLogic::createNo();
-			}
-		}
-
-		return TrinaryLogic::createMaybe();
+		return TrinaryLogic::createNo();
 	}
 
 	public function looseCompare(Type $type, PhpVersion $phpVersion): BooleanType

Original file line number	Diff line number	Diff line change
`@@ -1067,13 +1067,7 @@ public function isScalar(): TrinaryLogic`
`1067`	`1067`
`1068`	`1068`	`public function isError(): TrinaryLogic`
`1069`	`1069`	`{`
`1070`		`- if ($this->subtractedType !== null) {`
`1071`		`- if ($this->subtractedType->isSuperTypeOf(new ErrorType())->yes()) {`
`1072`		`- return TrinaryLogic::createNo();`
`1073`		`- }`
`1074`		`- }`
`1075`		`-`
`1076`		`- return TrinaryLogic::createMaybe();`
	`1070`	`+ return TrinaryLogic::createNo();`
`1077`	`1071`	`}`
`1078`	`1072`
`1079`	`1073`	`public function looseCompare(Type $type, PhpVersion $phpVersion): BooleanType`